Implement RuntimeHelpers.Box - #100561
#100561Merged
Merged
Implement RuntimeHelpers.Box#100561
Conversation
jkoritzinsky
requested review from
MichalStrehovsky,
lambdageek,
marek-safar and
thaystg
as code owners
April 2, 2024 23:14
|
Note regarding the |
jkotas
reviewed
Apr 2, 2024
jkotas
reviewed
Apr 2, 2024
jkotas
reviewed
Apr 3, 2024
This was referenced Apr 3, 2024
jkotas
reviewed
Apr 3, 2024
jkotas
reviewed
Apr 3, 2024
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
reviewed
Apr 3, 2024
This was referenced Apr 4, 2024
Closed
This was referenced Apr 4, 2024
This was referenced Apr 6, 2024
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97341
Implement RuntimeHelpers.Box with the same semantics as the
boxIL instruction. It creates a new box for value types, returns the existing object for reference types, and throws for byref types and pointers. It also throws a NullReferenceException when boxing a null by-ref (matching CoreCLR's existing behavior).