Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[main] Update dependencies from dotnet/roslyn-analyzers - #100520

#100520
Merged
ericstj merged 13 commits into
maindotnet/runtime:mainfrom
darc-main-8605e913-c842-4cfb-ace8-84f26c85ed12dotnet/runtime:darc-main-8605e913-c842-4cfb-ace8-84f26c85ed12Copy head branch name to clipboard
Apr 12, 2024
Merged

[main] Update dependencies from dotnet/roslyn-analyzers#100520
ericstj merged 13 commits into
maindotnet/runtime:mainfrom
darc-main-8605e913-c842-4cfb-ace8-84f26c85ed12dotnet/runtime:darc-main-8605e913-c842-4cfb-ace8-84f26c85ed12Copy head branch name to clipboard

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn-analyzers

  • Subscription: 5465c78f-1281-49a8-f9b0-08d9301a7704
  • Build: 20240408.3
  • Date Produced: April 9, 2024 3:50:07 AM UTC
  • Commit: 7455f63411369a962f769361d1a979a547756ada
  • Branch: refs/heads/main

…uild 20240401.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24201.2
…uild 20240402.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24202.3
…uild 20240403.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1
@stephentoub

stephentoub commented Apr 5, 2024

Copy link
Copy Markdown
Member

@MihaZupan, @buyaa-n, the recent SearchValues analyzer changes are causing a crash, eg

error AD0001: Analyzer 'Microsoft.NetCore.CSharp.Analyzers.Performance.CSharpUseSearchValuesAnalyzer' threw an exception of type 'System.ArgumentException' with message 'Syntax node is not within syntax tree'. 

@MihaZupan

MihaZupan commented Apr 5, 2024

Copy link
Copy Markdown
Member

Scanning through the changes in dotnet/roslyn-analyzers#7252 again nothing immediately stands out to me, I'll try to debug it on runtime locally

It's choking up on this line

int lastIdx = pathNameBytes.LastIndexOfAny(PathInternal.Utf8DirectorySeparators);

image

…uild 20240403.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1
@MihaZupan

Copy link
Copy Markdown
Member

Created dotnet/roslyn-analyzers#7279 that fixes this build, but I don't understand why it's needed (see PR description).

…uild 20240403.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1
…uild 20240403.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1
dotnet-maestro Bot added 2 commits April 8, 2024 12:21
…uild 20240403.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1
…uild 20240408.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3
…uild 20240408.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3
…uild 20240408.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3
pavelsavara and others added 2 commits April 12, 2024 13:11
…uild 20240408.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3
@ericstj

ericstj commented Apr 12, 2024

Copy link
Copy Markdown
Member

The one remaining failure from Build Analysis is a build failure:

error : Work item System.Text.RegularExpressions.Tests in job ac703041-e9f2-4478-9a58-f9b8e42fcd95 has failed.

However this is just a cascading error from the test which was already excused with #100715

@ericstj

ericstj commented Apr 12, 2024

Copy link
Copy Markdown
Member

/ba-g not flipping status of SendToHelix step in build, reluctant to create a known issue as this could be too broad.

@ericstj
ericstj merged commit fd18029 into main Apr 12, 2024
@dotnet-maestro
dotnet-maestro Bot deleted the darc-main-8605e913-c842-4cfb-ace8-84f26c85ed12 branch April 12, 2024 17:22
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240401.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24201.2

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240402.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24202.3

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240403.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240403.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240403.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240403.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240403.1

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24203.1

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240408.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240408.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240408.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20240408.3

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.24177.1 -> To Version 3.11.0-beta1.24208.3

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Pavel Savara <pavel.savara@gmail.com>
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflow for labeling automated codeflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.