Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

BinaryFormatter tests are no longer skipped when ran against source-built runtime #107534

Copy link
Copy link

Description

@tmds
Issue body actions

When building runtime under the source-build configuration, no functional BinaryFormatter is being built.

Tests that require a functional binary formatter are skipped based on:

[ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsBinaryFormatterSupported))]

These tests are no longer being skipped on the main branch. This causes 1000s of test failures across different test projects.

@adamsitnik I suspect this regressed in #106858 by removing the assembly version logic in DetermineBinaryFormatterSupport.

cc @ViktorHofer @omajid

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-System.Runtimebinaryformatter-migrationIssues related to the removal of BinaryFormatter and migrations away from itIssues related to the removal of BinaryFormatter and migrations away from itin-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.