TerminalLogger: Store output writer after setting it to UTF-8 - #9035
#9035Merged
rainersigwald merged 1 commit intoJul 14, 2023
dotnet:maindotnet/msbuild:mainfrom
rainersigwald:ungarble-utf-8-outputrainersigwald/msbuild:ungarble-utf-8-outputCopy head branch name to clipboard
Merged
TerminalLogger: Store output writer after setting it to UTF-8#9035rainersigwald merged 1 commit intodotnet:maindotnet/msbuild:mainfrom rainersigwald:ungarble-utf-8-outputrainersigwald/msbuild:ungarble-utf-8-outputCopy head branch name to clipboard
rainersigwald merged 1 commit into
dotnet:maindotnet/msbuild:mainfrom
rainersigwald:ungarble-utf-8-outputrainersigwald/msbuild:ungarble-utf-8-outputCopy head branch name to clipboard
Conversation
Fixes dotnet#9030 by capturing the stdout writer only _after_ setting the console encoding to support Unicode. The Console encoding setter works by discarding its internal writer and creating a new one with the new encoding.
ladipro
approved these changes
Jul 13, 2023
rainersigwald
enabled auto-merge (squash)
July 13, 2023 22:25
JanKrivanek
approved these changes
Jul 14, 2023
JanKrivanek
left a comment
Member
There was a problem hiding this comment.
Nice catch!
Approving, but I have strong opinion that the PR description absolutely has to be a code comment above the Output initialization line - otherwise some unintentional refactoring can regress this in the future
Member
|
Oh - I didn't realize the approve message doesn't block the automerge :-/ (noted for self for the future) @rainersigwald - can you still consider adding the explicit comment to the code? |
Merged
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Jul 14, 2023
Preserve the constraint in code as well as in the commit message for dotnet#9035.
Member
Author
Oh, boo, a comment in a file in the PR does block like that. |
rainersigwald
added a commit
that referenced
this pull request
Jul 14, 2023
YuliiaKovalova
pushed a commit
to YuliiaKovalova/msbuild
that referenced
this pull request
Jul 18, 2023
…#9035) Fixes dotnet#9030 by capturing the stdout writer only _after_ setting the console encoding to support Unicode. The Console encoding setter works by discarding its internal writer and creating a new one with the new encoding.
YuliiaKovalova
pushed a commit
to YuliiaKovalova/msbuild
that referenced
this pull request
Jul 18, 2023
Preserve the constraint in code as well as in the commit message for dotnet#9035.
This was referenced Jul 29, 2025
Closed
Closed
This was referenced Oct 15, 2025
Closed
This was referenced Nov 13, 2025
Closed
Open
This was referenced Dec 24, 2025
This was referenced Mar 27, 2026
This was referenced May 15, 2026
This was referenced Jun 10, 2026
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9030 by capturing the stdout writer only after setting the console encoding to support Unicode. The Console encoding setter works by discarding its internal writer and creating a new one with the new encoding.