Fix /warnaserror false positive overall success - #8953
#8953Merged
JaynieBai merged 1 commit intoJun 27, 2023
dotnet:maindotnet/msbuild:mainfrom
rokonec:rokonec/fix-warnaserror-flaky-bugrokonec/msbuild:rokonec/fix-warnaserror-flaky-bugCopy head branch name to clipboard
Merged
Fix /warnaserror false positive overall success#8953JaynieBai merged 1 commit intodotnet:maindotnet/msbuild:mainfrom rokonec:rokonec/fix-warnaserror-flaky-bugrokonec/msbuild:rokonec/fix-warnaserror-flaky-bugCopy head branch name to clipboard
JaynieBai merged 1 commit into
dotnet:maindotnet/msbuild:mainfrom
rokonec:rokonec/fix-warnaserror-flaky-bugrokonec/msbuild:rokonec/fix-warnaserror-flaky-bugCopy head branch name to clipboard
Conversation
where submission is considered to be done and assumed its final state
JanKrivanek
approved these changes
Jun 26, 2023
This was referenced Jul 29, 2025
Closed
Closed
This was referenced Oct 15, 2025
Closed
This was referenced Nov 13, 2025
Closed
Open
This was referenced Nov 26, 2025
Closed
Closed
This was referenced Dec 24, 2025
This was referenced Mar 27, 2026
This was referenced Jun 10, 2026
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8735, possibly #5689, #2845
Context
There were race condition when
ProjectFinishedlog message has been processed afterBuildResultevent. Even thoughProjectFinishedlog message event is always send beforeBuildResultevent from Node, becauseProjectFinishedis asyncronously routed byLoggingServicereversing order can and do often happen.Changes Made
Updating
_overallBuildSuccessin one place when submission is considered to be done and assumed its final state.Testing
Can't local repro.