Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update Strings.resx - #8941

#8941
Merged
JanKrivanek merged 2 commits into
dotnet:maindotnet/msbuild:mainfrom
asklar:patch-1asklar/msbuild:patch-1Copy head branch name to clipboard
Jun 26, 2023
Merged

Update Strings.resx#8941
JanKrivanek merged 2 commits into
dotnet:maindotnet/msbuild:mainfrom
asklar:patch-1asklar/msbuild:patch-1Copy head branch name to clipboard

Conversation

@asklar

@asklar asklar commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

removes the dot since URL parsers will treat the dot as part of the URL and show the whole thing as a link pointing to an invalid aka.ms.

removes the dot since URL parsers will treat the dot as part of the URL and show the whole thing as a link pointing to an invalid aka.ms.

@JanKrivanek JanKrivanek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @asklar for the contribution!
Can you please run this through the build - it will produce the missing localized resources and unblock the build.

@JanKrivanek

Copy link
Copy Markdown
Member

Thank you @asklar

@JanKrivanek
JanKrivanek merged commit a64167e into dotnet:main Jun 26, 2023
@asklar
asklar deleted the patch-1 branch June 26, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.