Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[main] Update dependencies from dotnet/arcade - #8658

#8658
Merged
JaynieBai merged 7 commits into
maindotnet/msbuild:mainfrom
darc-main-b8df15a0-e87d-433e-97c5-9cf003990823dotnet/msbuild:darc-main-b8df15a0-e87d-433e-97c5-9cf003990823Copy head branch name to clipboard
Apr 24, 2023
Merged

[main] Update dependencies from dotnet/arcade#8658
JaynieBai merged 7 commits into
maindotnet/msbuild:mainfrom
darc-main-b8df15a0-e87d-433e-97c5-9cf003990823dotnet/msbuild:darc-main-b8df15a0-e87d-433e-97c5-9cf003990823Copy head branch name to clipboard

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Apr 12, 2023

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: fc4faec0-9ee6-43b9-bc7a-08da8607f4c7
  • Build: 20230421.7
  • Date Produced: April 21, 2023 7:07:19 PM UTC
  • Commit: 3d9c9a4d3d893e903bb3295fd5b55b8e40699888
  • Branch: refs/heads/release/6.0

…411.7

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 6.0.0-beta.23167.1 -> To Version 6.0.0-beta.23211.7
@rainersigwald rainersigwald added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Apr 17, 2023
dotnet-maestro Bot and others added 3 commits April 20, 2023 12:34
…419.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 6.0.0-beta.23167.1 -> To Version 6.0.0-beta.23219.1
@JanKrivanek JanKrivanek removed the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Apr 20, 2023
@mmitche

mmitche commented Apr 20, 2023

Copy link
Copy Markdown
Member

@JanKrivanek That's exacty what I wanted, because I think the baselines are removable entirely. Let me try.

@mmitche

mmitche commented Apr 20, 2023

Copy link
Copy Markdown
Member

The latest arcade update brought in a fix that was preventing the sourcelink package from ever actually updating in arcade.

@mmitche

mmitche commented Apr 20, 2023

Copy link
Copy Markdown
Member

Apparently not. hold please.

@JanKrivanek

Copy link
Copy Markdown
Member

How about the proposed wildcard change? That went through green

@mmitche

mmitche commented Apr 20, 2023

Copy link
Copy Markdown
Member

My change should pass on the next arcade flow.

…420.3

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 6.0.0-beta.23167.1 -> To Version 6.0.0-beta.23220.3
@lewing

lewing commented Apr 21, 2023

Copy link
Copy Markdown
Member

@mmitche still failing in source-build

@mmitche

mmitche commented Apr 21, 2023

Copy link
Copy Markdown
Member

Sigh. dotnet/arcade#13252

…421.7

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XUnitExtensions
 From Version 6.0.0-beta.23167.1 -> To Version 6.0.0-beta.23221.7
@lewing

lewing commented Apr 23, 2023

Copy link
Copy Markdown
Member

This is ready to merge but I'm not authorized.

@JanKrivanek

Copy link
Copy Markdown
Member

@lewing MSBuild PRs need approval by 2 members of team, then get merged by on-duty member (due to VS and sdk insertions considerations)

@JanKrivanek JanKrivanek added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Apr 24, 2023
@JaynieBai
JaynieBai merged commit b3ac080 into main Apr 24, 2023
@JaynieBai
JaynieBai deleted the darc-main-b8df15a0-e87d-433e-97c5-9cf003990823 branch April 24, 2023 06:30
Forgind pushed a commit that referenced this pull request May 1, 2023
Context
Explict call to ComponentGovernanceComponentDetection@0 task (via /eng/common/templates/steps/component-governance.yml template) based on the branch name (so that this can be invoked for 'vs*' branches as well)

Note
This will be breaking until we consume this arcade update: dotnet/arcade@b1a9b86, it's now flowing to MSBuild main in this PR: #8658

Testing the changes on: https://github.com/dotnet/msbuild/tree/vs-test-only
ADO run: (vs* branch, the CG step injected) https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7672204&view=logs&j=bb592630-4b9d-53ad-3960-d954a70a95cf&t=424211a8-7b86-5e93-500e-ae39b50be1a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.