Simplify property/item type requirements Fixes #6985 - #6995
#6995Merged
rokonec merged 1 commit intoNov 1, 2021
dotnet:maindotnet/msbuild:mainfrom
Forgind:matchonmetadata-outside-targetsForgind/msbuild:matchonmetadata-outside-targetsCopy head branch name to clipboard
Merged
Simplify property/item type requirements Fixes #6985#6995rokonec merged 1 commit intodotnet:maindotnet/msbuild:mainfrom Forgind:matchonmetadata-outside-targetsForgind/msbuild:matchonmetadata-outside-targetsCopy head branch name to clipboard
rokonec merged 1 commit into
dotnet:maindotnet/msbuild:mainfrom
Forgind:matchonmetadata-outside-targetsForgind/msbuild:matchonmetadata-outside-targetsCopy head branch name to clipboard
Conversation
Member
|
This is causing us some issues with optional workloads and the sdk where we need to remove specific items outside of a target. |
Contributor
Author
|
Interested in providing extra validation for the proposed fix? I'm happy to help with getting you private bits if you'd like. |
cdmihai
approved these changes
Oct 28, 2021
benvillalobos
approved these changes
Oct 29, 2021
This was referenced Apr 15, 2026
This was referenced Jun 10, 2026
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6985
Context
RemoveOperation currently requires either not MatchOnMetadata or that the fragments are ItemSpec<ProjectProperty, ProjectItem>.ItemExpressionFragments. The latter is how we do it in tests, but in the wild, we use ProjectPropertyInstance and ProjectItemInstance. It sounds like those two should extend the other two, but they don't. I think it would be valid to make them do so, but this is a minimal change that resolves the issue such that it passes both tests and the repro case in #6985 by essentially letting how Remove is invoked dictate what the type has to be.
Changes Made
Switch to generic P and I.
Testing
Unit tests + verified the repro case no longer repros.