Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 5308962 - #6929

#6929
Merged
ladipro merged 2 commits into
maindotnet/msbuild:mainfrom
locfiles/a7369145-68c7-4ace-beb0-a3040e91e670dotnet/msbuild:locfiles/a7369145-68c7-4ace-beb0-a3040e91e670Copy head branch name to clipboard
Oct 14, 2021
Merged

Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 5308962#6929
ladipro merged 2 commits into
maindotnet/msbuild:mainfrom
locfiles/a7369145-68c7-4ace-beb0-a3040e91e670dotnet/msbuild:locfiles/a7369145-68c7-4ace-beb0-a3040e91e670Copy head branch name to clipboard

Conversation

@dotnet-bot

Copy link
Copy Markdown
Contributor

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/ceLocBug and log bugs for fixes. The wiki of the OneLocBuild task is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

ladipro added a commit that referenced this pull request Oct 12, 2021
### Context

The check is failing for loc PRs where `SYSTEM_PULLREQUEST_TARGETBRANCH` is set to `refs/head/main` because `origin/refs/head/main` is not a valid revision spec.

### Changes Made

Made the script add the `origin` remote reference only if the branch is not local.

### Testing

Tested by this PR and by #6929 after this PR is merged.
@ladipro
ladipro force-pushed the locfiles/a7369145-68c7-4ace-beb0-a3040e91e670 branch from ef34a70 to 893f24c Compare October 12, 2021 13:55
ladipro added a commit that referenced this pull request Oct 12, 2021
### Context

#6939 had a typo and didn't solve the problem with loc PRs.

### Changes Made

Fixed the revision spec prefix to `refs/heads` instead of `refs/head`.

### Testing

This PR and #6929 after this PR is merged.
@ladipro
ladipro force-pushed the locfiles/a7369145-68c7-4ace-beb0-a3040e91e670 branch from 893f24c to 745608d Compare October 12, 2021 14:51
@ladipro ladipro added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Oct 14, 2021
@ladipro
ladipro merged commit 53ffdaa into main Oct 14, 2021
@ladipro
ladipro deleted the locfiles/a7369145-68c7-4ace-beb0-a3040e91e670 branch October 25, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.