Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Rework the only .doc file into .md - #6910

#6910
Merged
ladipro merged 2 commits into
dotnet:maindotnet/msbuild:mainfrom
lfmundim:mainlfmundim/msbuild:mainCopy head branch name to clipboard
Oct 14, 2021
Merged

Rework the only .doc file into .md#6910
ladipro merged 2 commits into
dotnet:maindotnet/msbuild:mainfrom
lfmundim:mainlfmundim/msbuild:mainCopy head branch name to clipboard

Conversation

@lfmundim

@lfmundim lfmundim commented Oct 5, 2021

Copy link
Copy Markdown
Contributor

Fixes #6095

Context

As stated on the issue, there is a lone .doc file marked as confidential. As per comment from @marcpopMSFT there was no problem on removing the notice and leaving as is. Converted it to .md to be readable on repo and standardized

Changes Made

  • rewrote .doc file into .md
  • removed confidential notice

Testing

None required. Documentation changes

Notes

None

@dnfadmin

dnfadmin commented Oct 5, 2021

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@dnfadmin

dnfadmin commented Oct 5, 2021

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ lfmundim sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@rainersigwald rainersigwald left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated on the issue, there is a lone .doc file marked as confidential.

I think the ship has sailed on that one! 😂

Thanks!

Comment thread src/Shared/SharedCode.md Outdated
Fix typo

Co-authored-by: Rainer Sigwald <raines@microsoft.com>
@benvillalobos benvillalobos added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Oct 6, 2021
@ladipro
ladipro merged commit 886d599 into dotnet:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Confidential" notice in Shared Code.doc

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.