Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update test-running agent instructions for MTP+xUnit v3 - #13806

#13806
Merged
rainersigwald merged 3 commits into
maindotnet/msbuild:mainfrom
rainersigwald/test-flakiness-checkdotnet/msbuild:rainersigwald/test-flakiness-checkCopy head branch name to clipboard
May 19, 2026
Merged

Update test-running agent instructions for MTP+xUnit v3#13806
rainersigwald merged 3 commits into
maindotnet/msbuild:mainfrom
rainersigwald/test-flakiness-checkdotnet/msbuild:rainersigwald/test-flakiness-checkCopy head branch name to clipboard

Conversation

@rainersigwald

@rainersigwald rainersigwald commented May 18, 2026

Copy link
Copy Markdown
Member

I've watched agents struggle to run tests, and I think it's because #13482 made it so some of the stuff in our agent instructions was stale.

With this change both gpt-5.3-codex and claude-haiku-4.5 seemed to get the --filter-method syntax right in one shot when asked to run a unit test.

dotnet test --filter ... silently fails against this repo's MTP-using test projects (Unknown option --filter, Zero tests ran, exit 5). Replace the broken examples with the working -- --filter-method form, and call out the gotcha in AGENTS.md.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

🔍 Skill Validator Results

✅ All checks passed

Scope Checked
Skills 1
Agents 0
Total 1
Severity Count
--- ---:
❌ Errors 0
⚠️ Warnings 0
ℹ️ Advisories 0

Summary

Level Finding
ℹ️ Found 1 skill(s)
ℹ️ [running-unit-tests] 📊 running-unit-tests: 2,386 BPE tokens [chars/4: 2,317] (detailed ✓), 10 sections, 6 code blocks
ℹ️ ✅ All checks passed (1 skill(s))
Full validator output ```text Found 1 skill(s) [running-unit-tests] 📊 running-unit-tests: 2,386 BPE tokens [chars/4: 2,317] (detailed ✓), 10 sections, 6 code blocks ✅ All checks passed (1 skill(s)) ```

rainersigwald and others added 2 commits May 18, 2026 14:28
Several references conflated 'Microsoft.Testing.Platform' (the host) with 'xUnit v3 MTP runner' (the framework that provides --filter-method/--filter-class/--filter-trait and xUnit.* settings). Clarify which flags come from which layer so a future reader looking up MTP docs doesn't get confused about why --filter-method isn't there.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@rainersigwald rainersigwald changed the title docs: fix broken --filter examples in test instructions Update test-running agent instructions for MTP+xUnit v3 May 18, 2026
@rainersigwald rainersigwald self-assigned this May 18, 2026
@rainersigwald
rainersigwald marked this pull request as ready for review May 18, 2026 20:30
@rainersigwald
rainersigwald requested a review from a team as a code owner May 18, 2026 20:30
Copilot AI review requested due to automatic review settings May 18, 2026 20:30
@rainersigwald
rainersigwald enabled auto-merge (squash) May 18, 2026 20:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates repo agent/test-running documentation to reflect the xUnit v3 + Microsoft.Testing.Platform (MTP) migration (PR #13482), specifically the correct way to filter a single test when using dotnet test.

Changes:

  • Update AGENTS.md to use xUnit v3 native filtering via dotnet test ... -- --filter-method "*...*" instead of --filter ....
  • Update the running-unit-tests skill to explicitly call out that --filter is not applicable here and to standardize examples on -- --filter-method "*...*".

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
AGENTS.md Replaces stale single-test filtering guidance with xUnit v3/MTP-compatible -- --filter-method usage.
.github/skills/running-unit-tests/SKILL.md Aligns filtering/pitfalls section and examples with xUnit v3 MTP runner filtering flags.

@rainersigwald
rainersigwald merged commit 4052337 into main May 19, 2026
12 checks passed
@rainersigwald
rainersigwald deleted the rainersigwald/test-flakiness-check branch May 19, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.