Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[main] Source code updates from dotnet/dotnet - #12886

#12886
Merged
YuliiaKovalova merged 3 commits into
maindotnet/msbuild:mainfrom
darc-main-ba53a5bf-0445-44b8-ab8e-99e35b2b6a01dotnet/msbuild:darc-main-ba53a5bf-0445-44b8-ab8e-99e35b2b6a01Copy head branch name to clipboard
Dec 8, 2025
Merged

[main] Source code updates from dotnet/dotnet#12886
YuliiaKovalova merged 3 commits into
maindotnet/msbuild:mainfrom
darc-main-ba53a5bf-0445-44b8-ab8e-99e35b2b6a01dotnet/msbuild:darc-main-ba53a5bf-0445-44b8-ab8e-99e35b2b6a01Copy head branch name to clipboard

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Dec 6, 2025

Copy link
Copy Markdown
Contributor

Note

This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Associated changes in source repos

@dotnet-maestro
dotnet-maestro Bot requested a review from a team as a code owner December 6, 2025 02:08
@YuliiaKovalova
YuliiaKovalova merged commit 598283c into main Dec 8, 2025
16 checks passed
@YuliiaKovalova
YuliiaKovalova deleted the darc-main-ba53a5bf-0445-44b8-ab8e-99e35b2b6a01 branch December 8, 2025 12:15
@dfederm dfederm mentioned this pull request Jan 15, 2026
YuliiaKovalova pushed a commit that referenced this pull request Jan 19, 2026
I'm seeing this exception:

```
System.TypeInitializationException: The type initializer for 'Microsoft.Build.Eventing.MSBuildEventSource' threw an exception.
---> System.MissingMethodException: Method not found: 'Void System.Diagnostics.Tracing.EventSource..ctor(System.String, System.Guid)'.
   at Microsoft.Build.Eventing.MSBuildEventSource..ctor()
   at Microsoft.Build.Eventing.MSBuildEventSource..ctor()
   at Microsoft.Build.Eventing.MSBuildEventSource..cctor()
   --- End of inner exception stack trace ---
   at Microsoft.Build.Graph.ProjectGraph.<>c__DisplayClass41_0.<.ctor>g__BeginMeasurement|1()
   at Microsoft.Build.Graph.ProjectGraph..ctor(IEnumerable`1 entryPoints, ProjectCollection projectCollection, ProjectInstanceFactoryFunc projectInstanceFactory, Int32 degreeOfParallelism, CancellationToken cancellationToken)
   at Microsoft.Build.Graph.ProjectGraph..ctor(IEnumerable`1 entryPoints, ProjectCollection projectCollection, ProjectInstanceFactoryFunc projectInstanceFactory)
```

In ILSpy I see Microsoft.Build.Framework.dll
`18.3.0-preview-26055-101+e64f84d6312cdaf227d26aeabfa4817862404d59`
having:

```cs
    private MSBuildEventSource()
        : base("Microsoft-Build", new Guid(3561627800u, 33311, 22536, 76, 234, 30, 36, 233, 130, 202, 55))
    {
    }
```

But in `C:\Program
Files\dotnet\shared\Microsoft.NETCore.App\10.0.1\System.Private.CoreLib.dll`
(loaded in .NET 10) I see:

```cs
internal EventSource(Guid eventSourceGuid, string eventSourceName)
    : this(eventSourceGuid, eventSourceName, EventSourceSettings.EtwManifestEventFormat)
{
}
```

It's both internal and the args are backwards...
 
I believe this was introduced in #12886.
 
Which pulls in this change:
dotnet/runtime#121180
 
That seems to introduce a source generator which calls the internal ctor
of EventSource (and with different order). As that's internal to .NET, I
expect it was not intended to be applied here in MSBuild.

This change simply reverts the change to `MSBuildEventSource`.

Co-authored-by: AR-May <67507805+AR-May@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.