Remove GeneratedFilesOutputPath parameter from XamlPreCompile targets - #12885
#12885Merged
rainersigwald merged 4 commits intoDec 16, 2025
maindotnet/msbuild:mainfrom
copilot/remove-generatedfilesoutputpath-parameterdotnet/msbuild:copilot/remove-generatedfilesoutputpath-parameterCopy head branch name to clipboard
Merged
Remove GeneratedFilesOutputPath parameter from XamlPreCompile targets#12885rainersigwald merged 4 commits intomaindotnet/msbuild:mainfrom copilot/remove-generatedfilesoutputpath-parameterdotnet/msbuild:copilot/remove-generatedfilesoutputpath-parameterCopy head branch name to clipboard
rainersigwald merged 4 commits into
maindotnet/msbuild:mainfrom
copilot/remove-generatedfilesoutputpath-parameterdotnet/msbuild:copilot/remove-generatedfilesoutputpath-parameterCopy head branch name to clipboard
Conversation
Contributor
|
Hello @@copilot, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo. |
Co-authored-by: dsplaisted <145043+dsplaisted@users.noreply.github.com>
Co-authored-by: dsplaisted <145043+dsplaisted@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove GeneratedFilesOutputPath parameter from Csc task
Remove GeneratedFilesOutputPath parameter from XamlPreCompile target
Dec 5, 2025
rainersigwald
approved these changes
Dec 8, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the GeneratedFilesOutputPath parameter from the Csc task invocation in the XamlPreCompile target and updates the associated comment to document this intentional divergence from the CoreCompile target in Microsoft.CSharp.Core.targets.
Key changes:
- Removed
GeneratedFilesOutputPath="$(CompilerGeneratedFilesOutputPath)"parameter from Csc task in XamlPreCompile target - Updated comment to explicitly state that GeneratedFilesOutputPath is intentionally omitted
Co-authored-by: rainersigwald <3347530+rainersigwald@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Remove GeneratedFilesOutputPath parameter from XamlPreCompile target
Remove GeneratedFilesOutputPath parameter from XamlPreCompile targets
Dec 8, 2025
rainersigwald
approved these changes
Dec 8, 2025
baronfel
approved these changes
Dec 15, 2025
Member
|
@rainersigwald any reason to not merge this? |
Member
|
No, we should merge as soon as we have green perf ddrits again. |
rainersigwald
deleted the
copilot/remove-generatedfilesoutputpath-parameter
branch
December 16, 2025 15:21
This was referenced Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The XamlPreCompile targets in Microsoft.CSharp.CurrentVersion.targets and Microsoft.VisualBasic.CurrentVersion.targets were passing
GeneratedFilesOutputPathto the Csc and Vbc tasks, which is unnecessary for XAML pre-compilation scenarios.Changes Made
GeneratedFilesOutputPath="$(CompilerGeneratedFilesOutputPath)"parameter from the Csc task invocation in the XamlPreCompile target in Microsoft.CSharp.CurrentVersion.targetsGeneratedFilesOutputPath="$(CompilerGeneratedFilesOutputPath)"parameter from the Vbc task invocation in the XamlPreCompile target in Microsoft.VisualBasic.CurrentVersion.targetsTesting
Notes
This intentionally diverges from the CoreCompile targets in Microsoft.CSharp.Core.targets and Microsoft.VisualBasic.Core.targets, which retain the GeneratedFilesOutputPath parameter. Both C# and VB implementations now have consistent changes.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.