Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Official build: Run loc and build concurrently - #12871

#12871
Merged
ViktorHofer merged 1 commit into
dotnet:maindotnet/msbuild:mainfrom
rainersigwald:parallel-loc-in-official-buildrainersigwald/msbuild:parallel-loc-in-official-buildCopy head branch name to clipboard
Dec 4, 2025
Merged

Official build: Run loc and build concurrently#12871
ViktorHofer merged 1 commit into
dotnet:maindotnet/msbuild:mainfrom
rainersigwald:parallel-loc-in-official-buildrainersigwald/msbuild:parallel-loc-in-official-buildCopy head branch name to clipboard

Conversation

@rainersigwald

Copy link
Copy Markdown
Member

This should reduce our official build time by ~9 minutes by moving the Localization step off the critical path.

Before:
image

https://dev.azure.com/devdiv/DevDiv/\_build/results?buildId=12889574 shows it working (though it required some additional tweaks to get the loc stuff to run at all on a branch that's not main or vs*):

image

@rainersigwald rainersigwald self-assigned this Dec 3, 2025
@rainersigwald
rainersigwald requested a review from a team as a code owner December 3, 2025 23:06
Copilot AI review requested due to automatic review settings December 3, 2025 23:06
@rainersigwald rainersigwald added the Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. label Dec 3, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the official build pipeline by enabling parallel execution of the localization and build stages, reducing overall build time by approximately 9 minutes. Previously, the build stage implicitly depended on the localization stage to complete first. By explicitly setting dependsOn: [] on the build stage, both stages can now run concurrently. The post-build stage will still wait for the build stage to complete (via the default validateDependsOn: [build] parameter in the post-build template), ensuring the correct sequencing of critical build artifacts.

Key Changes

  • Added explicit empty dependency to the build stage to enable parallel execution with localization
  • Localization stage continues to run independently and can complete at any time
  • Post-build stage correctly waits for build stage but not localization

@ViktorHofer ViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I notice that as well

@ViktorHofer
ViktorHofer merged commit 3027cea into dotnet:main Dec 4, 2025
16 checks passed
@rainersigwald
rainersigwald deleted the parallel-loc-in-official-build branch December 4, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.