Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Disable localization for vs17.14 - #12619

#12619
Merged
JanProvaznik merged 2 commits into
dotnet:vs17.14dotnet/msbuild:vs17.14from
AR-May:update-loc-vs17.14AR-May/msbuild:update-loc-vs17.14Copy head branch name to clipboard
Oct 20, 2025
Merged

Disable localization for vs17.14#12619
JanProvaznik merged 2 commits into
dotnet:vs17.14dotnet/msbuild:vs17.14from
AR-May:update-loc-vs17.14AR-May/msbuild:update-loc-vs17.14Copy head branch name to clipboard

Conversation

@AR-May

@AR-May AR-May commented Oct 8, 2025

Copy link
Copy Markdown
Member

Part of #12522

Disable localization for vs17.14
We localize only the last release branch

@AR-May
AR-May requested a review from a team as a code owner October 8, 2025 11:18
Copilot AI review requested due to automatic review settings October 8, 2025 11:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables localization for the vs17.14 release by updating the EnableReleaseOneLocBuild flag and incrementing the version number. The changes support preparing vs17.14 for release without localization enabled.

  • Incremented VersionPrefix from 17.14.27 to 17.14.28
  • Disabled localization by setting EnableReleaseOneLocBuild to false

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/Versions.props Version bump to 17.14.28 to reflect the localization configuration change
.vsts-dotnet.yml Disabled localization for vs17.14 by setting EnableReleaseOneLocBuild to false

@AR-May

AR-May commented Oct 8, 2025

Copy link
Copy Markdown
Member Author

Note: this PR will not get merge conflict in 18.0 branch as we did not update the loc comment in vs18.0 branch or in main when we bumped the version to 18.0.

@JanProvaznik
JanProvaznik enabled auto-merge (squash) October 20, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.