Reuse static delegate rather than create a new one each call - #12542
#12542Closed
Erarndt wants to merge 1 commit into
dotnet:maindotnet/msbuild:mainfrom
Erarndt:dev/erarndt/targetFinishedTranslatorDelegateErarndt/msbuild:dev/erarndt/targetFinishedTranslatorDelegateCopy head branch name to clipboard
Closed
Reuse static delegate rather than create a new one each call#12542Erarndt wants to merge 1 commit intodotnet:maindotnet/msbuild:mainfrom Erarndt:dev/erarndt/targetFinishedTranslatorDelegateErarndt/msbuild:dev/erarndt/targetFinishedTranslatorDelegateCopy head branch name to clipboard
Erarndt wants to merge 1 commit into
dotnet:maindotnet/msbuild:mainfrom
Erarndt:dev/erarndt/targetFinishedTranslatorDelegateErarndt/msbuild:dev/erarndt/targetFinishedTranslatorDelegateCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes memory allocations in the LogMessagePacket class by replacing repeated delegate instantiations with a single static cached delegate. The change reduces ~22MB of allocations by reusing the same TargetFinishedTranslator delegate instance across all constructor calls instead of creating a new one each time.
Key Changes
- Added a static readonly field to cache the
TargetFinishedTranslatordelegate - Updated both constructors to use the cached delegate instead of creating new instances
Contributor
|
Coincidentally #12526 fully gets rid of |
teo-tsirpanis
left a comment
Contributor
There was a problem hiding this comment.
I think that Roslyn since some time, caches static method group delegates by itself.
| /// </summary> | ||
| internal LogMessagePacket(KeyValuePair<int, BuildEventArgs>? nodeBuildEvent) | ||
| : base(nodeBuildEvent, new TargetFinishedTranslator(TranslateTargetFinishedEvent)) | ||
| : base(nodeBuildEvent, targetFinishedTranslator) |
Contributor
There was a problem hiding this comment.
Suggested change
| : base(nodeBuildEvent, targetFinishedTranslator) | |
| : base(nodeBuildEvent, TranslateTargetFinishedEvent) |
| /// </summary> | ||
| private LogMessagePacket(ITranslator translator) | ||
| : base(translator, new TargetFinishedTranslator(TranslateTargetFinishedEvent)) | ||
| : base(translator, targetFinishedTranslator) |
Contributor
There was a problem hiding this comment.
Suggested change
| : base(translator, targetFinishedTranslator) | |
| : base(translator, TranslateTargetFinishedEvent) |
Comment on lines
+22
to
+23
| private static readonly TargetFinishedTranslator targetFinishedTranslator = new TargetFinishedTranslator(TranslateTargetFinishedEvent); | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| private static readonly TargetFinishedTranslator targetFinishedTranslator = new TargetFinishedTranslator(TranslateTargetFinishedEvent); |
YuliiaKovalova
approved these changes
Nov 6, 2025
Member
|
was addressed in scope of 84e6f07#diff-e90122e9ff329eb52633d20ba6d5d9d3bfebc5020a76eca5d6f32f95d6074be0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
The constructors for
LogMessagePacketallocate a newTargetFinishedTranslatordelegate for each call. The delegate function is static already, so this can be cached to avoid the repeated allocations. There are ~22MB of allocations total from two separate paths.Changes Made
Testing
Notes