Backport of fixing the contention condition caused by RegisterResolversManifests to vs 17.12 - #11642
#11642Closed
SimaTian wants to merge 2 commits into
vs17.12dotnet/msbuild:vs17.12from
backport-contention-condition-fix-pr11079dotnet/msbuild:backport-contention-condition-fix-pr11079Copy head branch name to clipboard
Closed
Backport of fixing the contention condition caused by RegisterResolversManifests to vs 17.12#11642SimaTian wants to merge 2 commits intovs17.12dotnet/msbuild:vs17.12from backport-contention-condition-fix-pr11079dotnet/msbuild:backport-contention-condition-fix-pr11079Copy head branch name to clipboard
SimaTian wants to merge 2 commits into
vs17.12dotnet/msbuild:vs17.12from
backport-contention-condition-fix-pr11079dotnet/msbuild:backport-contention-condition-fix-pr11079Copy head branch name to clipboard
Conversation
…11079) * Contention condition reproduction via unit test * updating the lists only after they're complete to avoid the contention. * Update src/Build/BackEnd/Components/SdkResolution/SdkResolverService.cs Co-authored-by: Rainer Sigwald <raines@microsoft.com> * addressing review comments * minor touchup * #if DEBUG fix * refactoring to get rid of #if directives * removing unnecessary include * variable rename --------- Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Contributor
Author
|
Duplicate of #11612 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11430
Context
backport of #11079
the relevant context is there.