Revert ".slnx support - use the new parser for .sln and .slnx (#10836)" - #11488
#11488Merged
rainersigwald merged 2 commits intoFeb 25, 2025
dotnet:vs17.13dotnet/msbuild:vs17.13from
rainersigwald:revert-SolutionPersistence-for-slnrainersigwald/msbuild:revert-SolutionPersistence-for-slnCopy head branch name to clipboard
Merged
Revert ".slnx support - use the new parser for .sln and .slnx (#10836)"#11488rainersigwald merged 2 commits intodotnet:vs17.13dotnet/msbuild:vs17.13from rainersigwald:revert-SolutionPersistence-for-slnrainersigwald/msbuild:revert-SolutionPersistence-for-slnCopy head branch name to clipboard
rainersigwald merged 2 commits into
dotnet:vs17.13dotnet/msbuild:vs17.13from
rainersigwald:revert-SolutionPersistence-for-slnrainersigwald/msbuild:revert-SolutionPersistence-for-slnCopy head branch name to clipboard
Conversation
rainersigwald
force-pushed
the
revert-SolutionPersistence-for-sln
branch
from
February 24, 2025 22:28
2ac2af3 to
39e0043
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't use the new parser from
Microsoft.VisualStudio.SolutionPersistenceto parse.slnfiles.Fixes #11463
Work item (Internal use): AB#2397817
Summary
Revert #10836 to return to the longstanding MSBuild private
.slnparser (but keep using the SolutionPersistence library for.slnx).Customer Impact
Three categories of problem:
NuGet.exerestores failed because they couldn't find the library (fixed in newer versions but reported via VS Feedback and Update to msbuild 17.13 breaks builds microsoft/dotnet-framework-docker#1213.NuGet.exerestores can fail if the path to 64-bit MSBuild is specified explicitlyAll manifest as build or NuGet restore breaks with no obvious workaround (but once discovered the changewave opt-out environment variable works).
Regression?
Yes, in 17.13/9.0.200 due to adopting the common SolutionPersistence library instead of our homegrown sln parser.
Testing
Unit tests + manual scenario tests.
Risk
Low, clean revert to earlier behavior for
.sln.