Use SequenceEqual in win32 GetFullPath - #10706
#10706Merged
YuliiaKovalova merged 2 commits intoOct 2, 2024
dotnet:maindotnet/msbuild:mainfrom
rainersigwald:sequenceequal-windows-getfullpathrainersigwald/msbuild:sequenceequal-windows-getfullpathCopy head branch name to clipboard
Merged
Use SequenceEqual in win32 GetFullPath#10706YuliiaKovalova merged 2 commits intodotnet:maindotnet/msbuild:mainfrom rainersigwald:sequenceequal-windows-getfullpathrainersigwald/msbuild:sequenceequal-windows-getfullpathCopy head branch name to clipboard
YuliiaKovalova merged 2 commits into
dotnet:maindotnet/msbuild:mainfrom
rainersigwald:sequenceequal-windows-getfullpathrainersigwald/msbuild:sequenceequal-windows-getfullpathCopy head branch name to clipboard
Conversation
This should be slightly more efficient since it's vectorizable.
JanKrivanek
approved these changes
Sep 26, 2024
Member
|
Some constructs are not supported in |
Member
Author
|
Fixed by replacing the body of the existing function, under an ifdef. *extremely deep sigh* |
MichalPavlik
approved these changes
Sep 27, 2024
This was referenced Jul 28, 2025
This was referenced Aug 4, 2025
This was referenced Aug 15, 2025
This was referenced Apr 8, 2026
This was referenced Apr 16, 2026
This was referenced Apr 23, 2026
Closed
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be slightly more efficient since it's vectorizable.