Change throwaway parameter to include out and add test - #10438
#10438Merged
JanKrivanek merged 4 commits intoOct 9, 2024
dotnet:maindotnet/msbuild:mainfrom
Forgind:fix-throwaway-parameterForgind/msbuild:fix-throwaway-parameterCopy head branch name to clipboard
Merged
Change throwaway parameter to include out and add test#10438JanKrivanek merged 4 commits intodotnet:maindotnet/msbuild:mainfrom Forgind:fix-throwaway-parameterForgind/msbuild:fix-throwaway-parameterCopy head branch name to clipboard
JanKrivanek merged 4 commits into
dotnet:maindotnet/msbuild:mainfrom
Forgind:fix-throwaway-parameterForgind/msbuild:fix-throwaway-parameterCopy head branch name to clipboard
Conversation
Forgind
marked this pull request as ready for review
August 15, 2024 22:01
Forgind
force-pushed
the
fix-throwaway-parameter
branch
from
August 15, 2024 23:08
c14666e to
161f84d
Compare
Contributor
Author
|
I haven't come up with any more ways that this is broken; have you? |
Forgind
force-pushed
the
fix-throwaway-parameter
branch
from
August 16, 2024 13:14
161f84d to
7316d1e
Compare
Forgind
force-pushed
the
fix-throwaway-parameter
branch
from
August 16, 2024 13:25
7316d1e to
d71daa9
Compare
rainersigwald
approved these changes
Sep 25, 2024
JanKrivanek
approved these changes
Sep 26, 2024
JanKrivanek
left a comment
Member
There was a problem hiding this comment.
Looks good!
I have 1 suggestion for slight improvement - but not a must have.
Forgind
commented
Sep 27, 2024
JanKrivanek
enabled auto-merge (squash)
October 9, 2024 10:40
This was referenced Jul 28, 2025
This was referenced Aug 4, 2025
This was referenced Apr 8, 2026
This was referenced Apr 16, 2026
This was referenced Apr 23, 2026
Closed
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10435
Context
#10209 was generous with what it interpreted as a throwaway parameter: underscores were often misinterpreted as throwaway parameters. This changes it to require
out _instead of just_, which should resolve the problem.Changes Made
Look for
out _instead of just_Testing
Created a new unit test to distinguish between _ and out _
Notes
Alternative to #10435
I searched github for all instances of
out _in .props, .targets, and .*proj files and found none that seemed problematic, giving me some confidence in this change. I also looked for instances of _ in .targets files and found plenty of examples that were broken with #10209, indicating that that search would've prevented this problem.@rainersigwald, leaving this as a draft until you've had a chance to try to think of potential problems with this approach. I was satisfied with my github search.