Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up duplicate path normalization code in the HybridWebView implementation by consolidating functionality into a centralized utility.
- Removes local
PathUtilsclass and replaces it with existingFileSystemUtils.NormalizePath - Adds necessary
usingstatement forMicrosoft.Maui.Storage - Eliminates code duplication by leveraging shared functionality
| } | ||
|
|
||
| filename = PathUtils.NormalizePath(filename); | ||
| filename = FileSystemUtils.NormalizePath(filename); |
There was a problem hiding this comment.
This change replaces a local PathUtils.NormalizePath method with FileSystemUtils.NormalizePath, which could be a breaking change if the behavior differs between implementations. Please verify that FileSystemUtils.NormalizePath has identical behavior to the removed PathUtils.NormalizePath method, and alert reviewers that this is potentially a breaking change.
mattleibow
approved these changes
Aug 4, 2025
SuthiYuvaraj
pushed a commit
to SuthiYuvaraj/maui
that referenced
this pull request
Aug 12, 2025
rmarinho
pushed a commit
that referenced
this pull request
Aug 13, 2025
This was referenced Aug 15, 2025
Closed
Bump Microsoft.AspNetCore.Components.WebView.Maui from 9.0.90 to 9.0.100
ILoveDotNet/ilovedotnet#467
Merged
5 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Clean up duplicate path normalization code in HybridWebView.
Issues Fixed
Fixes #23668