Add formatter for the charset .editorconfig option - #330
#330Merged
JoeRobich merged 1 commit intoAug 15, 2019
dotnet:masterdotnet/format:masterfrom
JoeRobich:add-charset-formatterJoeRobich/format:add-charset-formatterCopy head branch name to clipboard
Merged
Add formatter for the charset .editorconfig option#330JoeRobich merged 1 commit intodotnet:masterdotnet/format:masterfrom JoeRobich:add-charset-formatterJoeRobich/format:add-charset-formatterCopy head branch name to clipboard
JoeRobich merged 1 commit into
dotnet:masterdotnet/format:masterfrom
JoeRobich:add-charset-formatterJoeRobich/format:add-charset-formatterCopy head branch name to clipboard
Conversation
RikkiGibson
self-requested a review
August 13, 2019 05:42
RikkiGibson
reviewed
Aug 13, 2019
RikkiGibson
reviewed
Aug 13, 2019
RikkiGibson
approved these changes
Aug 13, 2019
RikkiGibson
reviewed
Aug 13, 2019
| var codeEncoding = CharsetFormatter.GetCharset(codeValue); | ||
| var expectedEncoding = CharsetFormatter.GetCharset(expectedValue); | ||
|
|
||
| var testCode = "class C { }"; |
Member
There was a problem hiding this comment.
It might be worthwhile to verify that the encoding really changed the test code contents, perhaps by making the test class name a more complex character, and including a byte[] with the final raw content in the InlineData
Member
Author
There was a problem hiding this comment.
Yeah, we will need to make an integration test for that. There wouldn't be any change until the workspace has saved the document changes. Since these tests use AdhocWorkspace that isn't possible because it doesn't implement persistence.
JoeRobich
force-pushed
the
add-charset-formatter
branch
from
August 14, 2019 16:25
1e95981 to
87b050c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
charsetsupport was requested by the community and should wrap up our support for the the core .editorconfig options.