Log formatting change details when in dry-run mode - #249
#249Merged
JoeRobich merged 5 commits intoJul 13, 2019
masterdotnet/format:masterfrom
dev/jorobich/log-format-locationsdotnet/format:dev/jorobich/log-format-locationsCopy head branch name to clipboard
Merged
Log formatting change details when in dry-run mode#249JoeRobich merged 5 commits intomasterdotnet/format:masterfrom dev/jorobich/log-format-locationsdotnet/format:dev/jorobich/log-format-locationsCopy head branch name to clipboard
JoeRobich merged 5 commits into
masterdotnet/format:masterfrom
dev/jorobich/log-format-locationsdotnet/format:dev/jorobich/log-format-locationsCopy head branch name to clipboard
Conversation
Member
Author
|
@jmarolf PTAL |
JoeRobich
force-pushed
the
dev/jorobich/log-format-locations
branch
from
July 12, 2019 03:25
b3e1329 to
b7d4e66
Compare
JoeRobich
force-pushed
the
dev/jorobich/log-format-locations
branch
from
July 12, 2019 03:44
b7d4e66 to
2f0bd58
Compare
jmarolf
self-requested a review
July 12, 2019 22:44
jmarolf
reviewed
Jul 12, 2019
jmarolf
approved these changes
Jul 12, 2019
JoeRobich
force-pushed
the
dev/jorobich/log-format-locations
branch
from
July 13, 2019 00:14
9e50060 to
60540e1
Compare
JoeRobich
added a commit
to JoeRobich/format
that referenced
this pull request
Jul 13, 2019
* Log format locations * Use workspace path for relative filenames * Log format change details only when in dry-run mode * Fix FormatLocations test to work x-plat * Localize formatter warning descriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides the necessary information for #247. Since the Roslyn whitespace formatter fixes all whitespace formatting options in one operation there are not per-rule messages for whitespace changes.
Sample output:
Fixes #90