Added final newline formatter - #133
#133Merged
JoeRobich merged 2 commits intoMay 24, 2019
dotnet:masterdotnet/format:masterfrom
JoeRobich:add-final-newline-formatterJoeRobich/format:add-final-newline-formatterCopy head branch name to clipboard
Merged
Added final newline formatter#133JoeRobich merged 2 commits intodotnet:masterdotnet/format:masterfrom JoeRobich:add-final-newline-formatterJoeRobich/format:add-final-newline-formatterCopy head branch name to clipboard
JoeRobich merged 2 commits into
dotnet:masterdotnet/format:masterfrom
JoeRobich:add-final-newline-formatterJoeRobich/format:add-final-newline-formatterCopy head branch name to clipboard
Conversation
sharwell
reviewed
May 8, 2019
Member
Author
|
@sharwell I had assumed that we were letting the Editor handle some of these core .editorconfig options. I can add it there instead. |
Contributor
|
Not all options would apply there, but it seems these two would. |
JoeRobich
marked this pull request as ready for review
May 24, 2019 17:15
Member
Author
|
@sharwell I see that Roslyn already has an issue to support final newline in the formatter (dotnet/roslyn#33468). Going to merge this and we can remove when the functionality is implemented in Roslyn. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new formatter for the
insert_final_newlineeditorconfig option.Closes #111