Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Tweak OpenAI JSON schema transforms - #6523

#6523
Merged
stephentoub merged 2 commits into
dotnet:maindotnet/extensions:mainfrom
stephentoub:openaijsonstephentoub/extensions:openaijsonCopy head branch name to clipboard
Jun 18, 2025
Merged

Tweak OpenAI JSON schema transforms#6523
stephentoub merged 2 commits into
dotnet:maindotnet/extensions:mainfrom
stephentoub:openaijsonstephentoub/extensions:openaijsonCopy head branch name to clipboard

Conversation

@stephentoub

@stephentoub stephentoub commented Jun 17, 2025

Copy link
Copy Markdown
Member

Only require all properties and force additionalProperties: false when strict is set or when structured output is used.

Also update the OpenAI assistant chat client to apply the transforms.

Closes #6483

Microsoft Reviewers: Open in CodeFlow

@stephentoub
stephentoub requested a review from a team as a code owner June 17, 2025 21:57
@github-actions github-actions Bot added the area-ai Microsoft.Extensions.AI libraries label Jun 17, 2025
Only require all properties and force additionalProperties: false when strict is set or when structured output is used.

Also update the OpenAI assistant chat client to apply the transforms.
Comment thread src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIAssistantChatClient.cs Outdated

@eiriktsarpalis eiriktsarpalis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I take it our OpenAI integration tests are passing with these changes?

@stephentoub

Copy link
Copy Markdown
Member Author

Thanks. I take it our OpenAI integration tests are passing with these changes?

Yup.

@stephentoub
stephentoub merged commit d323577 into dotnet:main Jun 18, 2025
6 checks passed
@stephentoub
stephentoub deleted the openaijson branch June 18, 2025 18:24
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ai Microsoft.Extensions.AI libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[M.E.AI] Tool call format problems

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.