Update dev-server data import to reflect runtime import quirks - #6257
#6257Merged
peterwald merged 1 commit intoApr 7, 2025
dotnet:maindotnet/extensions:mainfrom
peterwald:default-dev-importpeterwald/extensions:default-dev-importCopy head branch name to clipboard
Merged
Update dev-server data import to reflect runtime import quirks#6257peterwald merged 1 commit intodotnet:maindotnet/extensions:mainfrom peterwald:default-dev-importpeterwald/extensions:default-dev-importCopy head branch name to clipboard
peterwald merged 1 commit into
dotnet:maindotnet/extensions:mainfrom
peterwald:default-dev-importpeterwald/extensions:default-dev-importCopy head branch name to clipboard
Conversation
shyamnamboodiripad
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for #6252
The previously noted bug only occurs in the local development server. It is caused by the fact that we use runtime
import()to bring in the data from a json file in the local folder.import()assumes we are importing code and treats it as a module, creating a module namespace object. This causes the data to be duplicated under adefaultkey.In this PR we update the dev code to reference the data loaded into the default import, which normalizes the data structure.
Microsoft Reviewers: Open in CodeFlow