Add default value for namedArg in Microsoft.Gen.Metrics.parser - #6238
#6238Merged
evgenyfedorov2 merged 2 commits intoMay 27, 2025
dotnet:maindotnet/extensions:mainfrom
BowenYang666:u/bowen/addDefaultBowenYang666/dotnetextensionsFork:u/bowen/addDefaultCopy head branch name to clipboard
Merged
Add default value for namedArg in Microsoft.Gen.Metrics.parser#6238evgenyfedorov2 merged 2 commits intodotnet:maindotnet/extensions:mainfrom BowenYang666:u/bowen/addDefaultBowenYang666/dotnetextensionsFork:u/bowen/addDefaultCopy head branch name to clipboard
evgenyfedorov2 merged 2 commits into
dotnet:maindotnet/extensions:mainfrom
BowenYang666:u/bowen/addDefaultBowenYang666/dotnetextensionsFork:u/bowen/addDefaultCopy head branch name to clipboard
Conversation
Member
|
@BowenYang666 can you describe the situation where this change fixes an issue? I'm not against the change but would like more details in the PR. |
Contributor
Author
@dariusclay Besides that, it's my first time contributing this repo. So I'm finding some simple code that I can fix to get started. |
evgenyfedorov2
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add default value for namedArg in Microsoft.Gen.Metrics.parser
Microsoft Reviewers: Open in CodeFlow