Update ordering in CODEOWNERS - #6085
#6085Merged
RussKie merged 1 commit intoMar 11, 2025
dotnet:maindotnet/extensions:mainfrom
shyamnamboodiripad:codeownersshyamnamboodiripad/extensions:codeownersCopy head branch name to clipboard
Merged
Update ordering in CODEOWNERS#6085RussKie merged 1 commit intodotnet:maindotnet/extensions:mainfrom shyamnamboodiripad:codeownersshyamnamboodiripad/extensions:codeownersCopy head branch name to clipboard
RussKie merged 1 commit into
dotnet:maindotnet/extensions:mainfrom
shyamnamboodiripad:codeownersshyamnamboodiripad/extensions:codeownersCopy head branch name to clipboard
Conversation
Place the rules for MEAI.Evaluation after MEAI since the last matching pattern always takes most precendence. I was seeing that `@dotnet/dotnet-extensions-ai` was being included as a reviewer for changes in the `/src/Libraries/Microsoft.Extensions.AI.Evaluation` folder. I think this was happening because the rule for this folder appeared *before* the rule for `/src/Libraries/Microsoft.Extensions.AI.*` in the CODEOWNERS file, and because the last matching pattern always takes precedence. This change should hopefully remedy this and ensure that only @dotnet/dotnet-extensions-ai-evaluation is included as a reviewer for changes in the `/src/Libraries/Microsoft.Extensions.AI.Evaluation` folder.
Contributor
Author
|
FYI @peterwald |
shyamnamboodiripad
enabled auto-merge (squash)
March 11, 2025 23:41
shyamnamboodiripad
disabled auto-merge
March 11, 2025 23:42
RussKie
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Place the rules for MEAI.Evaluation after MEAI since the last matching pattern always takes most precedence. (Reference: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file)
I was seeing that
@dotnet/dotnet-extensions-aiwas being included as a reviewer for changes in the/src/Libraries/Microsoft.Extensions.AI.Evaluationfolder. I think this was happening because the rule for this folder appeared before the rule for/src/Libraries/Microsoft.Extensions.AI.*in the CODEOWNERS file, and because the last matching pattern always takes precedence.The order change should hopefully remedy this and ensure that only
@dotnet/dotnet-extensions-ai-evaluationis included as a reviewer for changes in the/src/Libraries/Microsoft.Extensions.AI.Evaluationfolder.Microsoft Reviewers: Open in CodeFlow