Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Tweak a comment in FunctionInvokingChatClient - #5910

#5910
Merged
stephentoub merged 1 commit into
dotnet:maindotnet/extensions:mainfrom
stephentoub:tweakcommentstephentoub/extensions:tweakcommentCopy head branch name to clipboard
Feb 17, 2025
Merged

Tweak a comment in FunctionInvokingChatClient#5910
stephentoub merged 1 commit into
dotnet:maindotnet/extensions:mainfrom
stephentoub:tweakcommentstephentoub/extensions:tweakcommentCopy head branch name to clipboard

Conversation

@stephentoub

@stephentoub stephentoub commented Feb 15, 2025

Copy link
Copy Markdown
Member
Microsoft Reviewers: Open in CodeFlow

@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.Ollama Line 80 78.2 🔻
Microsoft.Extensions.AI.OpenAI Line 77 67.92 🔻
Microsoft.Extensions.AI.OpenAI Branch 77 49.8 🔻
Microsoft.Extensions.AI.Evaluation.Console Line 88 8.26 🔻
Microsoft.Extensions.AI.Evaluation.Console Branch 88 17.07 🔻
Microsoft.Extensions.Caching.Hybrid Line 86 82.69 🔻
Microsoft.Extensions.AI.Evaluation.Quality Line 88 7.57 🔻
Microsoft.Extensions.AI.Evaluation.Quality Branch 88 16.42 🔻
Microsoft.Extensions.AI.Evaluation.Reporting Line 88 72.06 🔻
Microsoft.Extensions.AI.Evaluation.Reporting Branch 88 64.8 🔻
Microsoft.Extensions.AI.AzureAIInference Line 91 90.09 🔻
Microsoft.Extensions.AI.AzureAIInference Branch 91 86.76 🔻
Microsoft.Extensions.AI.Abstractions Branch 83 82.85 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻
Microsoft.Extensions.AI.Evaluation Line 88 58.67 🔻
Microsoft.Extensions.AI.Evaluation Branch 88 56.67 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=953614&view=codecoverage-tab

@stephentoub
stephentoub merged commit 7226fd0 into dotnet:main Feb 17, 2025
@jeffhandley jeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
@stephentoub
stephentoub deleted the tweakcomment branch March 21, 2025 14:26
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ai Microsoft.Extensions.AI libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.