Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Move AIFunction parameter schematization from parameter level to function level. - #5826

#5826
Merged
eiriktsarpalis merged 4 commits into
dotnet:maindotnet/extensions:mainfrom
eiriktsarpalis:feature/function-metadataeiriktsarpalis/extensions:feature/function-metadataCopy head branch name to clipboard
Feb 7, 2025
Merged

Move AIFunction parameter schematization from parameter level to function level.#5826
eiriktsarpalis merged 4 commits into
dotnet:maindotnet/extensions:mainfrom
eiriktsarpalis:feature/function-metadataeiriktsarpalis/extensions:feature/function-metadataCopy head branch name to clipboard

Conversation

@eiriktsarpalis

@eiriktsarpalis eiriktsarpalis commented Jan 29, 2025

Copy link
Copy Markdown
Member

Fix #5655.

@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.Ollama Line 80 77.94 🔻
Microsoft.Extensions.AI.Ollama Branch 80 79.73 🔻
Microsoft.Extensions.Caching.Hybrid Line 86 77.7 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.AzureAIInference 91 92
Microsoft.Extensions.AI.Abstractions 83 85
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=933837&view=codecoverage-tab

@eiriktsarpalis
eiriktsarpalis force-pushed the feature/function-metadata branch from 0a3b415 to ec8d3ab Compare February 3, 2025 18:39
@eiriktsarpalis
eiriktsarpalis marked this pull request as ready for review February 3, 2025 18:41
@eiriktsarpalis
eiriktsarpalis requested a review from a team as a code owner February 3, 2025 18:41
@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.Ollama Line 80 78.24 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.AI.AzureAIInference 91 92
Microsoft.Extensions.AI.Abstractions 83 85

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=938548&view=codecoverage-tab

Comment thread src/Libraries/Microsoft.Extensions.AI.Ollama/OllamaChatClient.cs Outdated
Comment thread src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIModelMapper.ChatCompletion.cs Outdated
Comment thread src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIRealtimeExtensions.cs Outdated
Comment thread src/Libraries/Microsoft.Extensions.AI.OpenAI/OpenAIRealtimeExtensions.cs Outdated
@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.Ollama Line 80 78.11 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.AzureAIInference 91 92
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.AI.Abstractions 83 85

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=939708&view=codecoverage-tab

@RussKie RussKie added the area-ai Microsoft.Extensions.AI libraries label Feb 4, 2025
@eiriktsarpalis
eiriktsarpalis requested review from a team and stephentoub February 5, 2025 15:36
@eiriktsarpalis
eiriktsarpalis enabled auto-merge (squash) February 7, 2025 17:10
@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 82.77 🔻
Microsoft.Extensions.AI.Ollama Line 80 78.11 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.AzureAIInference 91 92
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.AI.Abstractions 83 85

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=944418&view=codecoverage-tab

@eiriktsarpalis
eiriktsarpalis merged commit 7f98df2 into dotnet:main Feb 7, 2025
@eiriktsarpalis
eiriktsarpalis deleted the feature/function-metadata branch February 7, 2025 17:58
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ai Microsoft.Extensions.AI libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microsoft.Extensions.AI.AIFunctionMetadata should allow to be initialized with a json schema string

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.