Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Inheritdoc fixes - #5823

#5823
Merged
RussKie merged 4 commits into
maindotnet/extensions:mainfrom
inheritdoc-docsdotnet/extensions:inheritdoc-docsCopy head branch name to clipboard
Jan 29, 2025
Merged

Inheritdoc fixes#5823
RussKie merged 4 commits into
maindotnet/extensions:mainfrom
inheritdoc-docsdotnet/extensions:inheritdoc-docsCopy head branch name to clipboard

Conversation

@gewarren

@gewarren gewarren commented Jan 28, 2025

Copy link
Copy Markdown
Contributor
Microsoft Reviewers: Open in CodeFlow

@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.Ollama Line 80 77.96 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.AI.OpenAI 77 78

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=932584&view=codecoverage-tab

Comment thread src/Libraries/Microsoft.Extensions.AI/ChatCompletion/CachingChatClient.cs Outdated
@RussKie
RussKie enabled auto-merge (squash) January 29, 2025 00:16
@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.AI.Ollama Line 80 77.96 🔻
Microsoft.Gen.MetadataExtractor Line 98 57.35 🔻
Microsoft.Gen.MetadataExtractor Branch 98 62.5 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89
Microsoft.Extensions.AI.OpenAI 77 78

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=932809&view=codecoverage-tab

@RussKie
RussKie merged commit 142f094 into main Jan 29, 2025
@RussKie
RussKie deleted the inheritdoc-docs branch January 29, 2025 03:50
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 28, 2025
@github-actions github-actions Bot added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ai Microsoft.Extensions.AI libraries documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.