Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix schema generation for floating point types - #5788

#5788
Merged
eiriktsarpalis merged 2 commits into
dotnet:maindotnet/extensions:mainfrom
eiriktsarpalis:trim-numeric-schemaseiriktsarpalis/extensions:trim-numeric-schemasCopy head branch name to clipboard
Jan 10, 2025
Merged

Fix schema generation for floating point types#5788
eiriktsarpalis merged 2 commits into
dotnet:maindotnet/extensions:mainfrom
eiriktsarpalis:trim-numeric-schemaseiriktsarpalis/extensions:trim-numeric-schemasCopy head branch name to clipboard

Conversation

@eiriktsarpalis

@eiriktsarpalis eiriktsarpalis commented Jan 10, 2025

Copy link
Copy Markdown
Member

Fix #5787.

Microsoft Reviewers: Open in CodeFlow

@SteveSandersonMS SteveSandersonMS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@eiriktsarpalis
eiriktsarpalis enabled auto-merge (squash) January 10, 2025 14:35
@dotnet-comment-bot

Copy link
Copy Markdown
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=913370&view=codecoverage-tab

@eiriktsarpalis
eiriktsarpalis merged commit b86638d into dotnet:main Jan 10, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 10, 2025
@jeffhandley jeffhandley added the area-ai Microsoft.Extensions.AI libraries label Mar 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ai Microsoft.Extensions.AI libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Structured output schema generation is too loose for decimal/double/float

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.