Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

33196 command timeout allow zero - #33198

#33198
Merged
ajcvickers merged 3 commits into
dotnet:maindotnet/efcore:mainfrom
SteSinger:33196_CommandTimeout_allow_zeroSteSinger/efcore:33196_CommandTimeout_allow_zeroCopy head branch name to clipboard
Mar 1, 2024
Merged

33196 command timeout allow zero#33198
ajcvickers merged 3 commits into
dotnet:maindotnet/efcore:mainfrom
SteSinger:33196_CommandTimeout_allow_zeroSteSinger/efcore:33196_CommandTimeout_allow_zeroCopy head branch name to clipboard

Conversation

@SteSinger

@SteSinger SteSinger commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

Allow zero for WithCommandTimeout.
Tests to check that WithCommandTimeout allows zero and rejects negative values

Fixes #33196

Stephan Singer added 3 commits February 29, 2024 11:50
Tests to check that WithCommandTimeout allows zero and rejects negative values
Tests to check that WithCommandTimeout allows zero and rejects negative values

Fixes dotnet#33196
@SteSinger

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

@ajcvickers ajcvickers removed the blocked label Mar 1, 2024
@ajcvickers
ajcvickers merged commit cf8c023 into dotnet:main Mar 1, 2024
@ajcvickers

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

@ajcvickers ajcvickers modified the milestone: 9.0.0-preview2 Mar 1, 2024
This was referenced Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RelationalDbContextOptionsBuilder.CommandTimeout should accept zero as a valid value

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.