Fix Windows x86 Guardian baselines - #7993
#7993Fix Windows x86 Guardian baselines#7993ViktorHofer merged 2 commits intomaindotnet/dotnet:mainfrom mmitche/guardian-windows-x86-baselinedotnet/dotnet:mmitche/guardian-windows-x86-baselineCopy head branch name to clipboard
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 68775560-f768-4761-8225-66ae7d08d918
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Updates Microsoft Guardian baseline entries so BA2007 suppressions for WPF runtime binaries align with the current Windows x86 outputs in the dotnet/dotnet VMR build.
Changes:
- Replaces two BA2007 baseline records (signatures + alternative signatures) for
DirectWriteForwarder.dllandSystem.Printing.dll. - Updates
uriBaseIdand timestamps to point at the unified build 3032528 Windows x86 symbols package output.
Comments suppressed due to low confidence (1)
.config/guardian/.gdnbaselines:327
- Same issue as above: this assembly is packaged under
runtimes/win-x86/lib/...in the WindowsDesktop runtime pack layout (see windowsdesktop sfx props). Usinglib/net11.0/...here may prevent the baseline from matching the scanned file path.
],
"target": "lib/net11.0/System.Printing.dll",
"uriBaseId": "file:///D:/a/_work/_temp/1espt_iba/a_archives_0/artifacts/assets/Release/assets/symbols/dotnet-dotnet/20260727.5/runtime_win-x86_Microsoft_DotNet_Wpf_GitHub_11_0_0-rc_1_26377_105_symbols_nupkg/",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@akoeplinger Might need both x86 and x64 baselines. Checking. |
|
yeah I think you'll need both. I took mine directly from the uploaded .gdnbaselines file from the Windows x64 run |
ViktorHofer
left a comment
There was a problem hiding this comment.
Do you also need different baselines for win-arm64?
|
good point, Arm has been failing earlier recently but binskim did fail in https://dev.azure.com/dnceng/internal/_build/results?buildId=3032807&view=logs&j=e45a3293-4024-5a66-d70f-cda470bd6fb5&t=65ae88fa-2931-5e34-26a7-b8ed76bf76f5. will add |
|
Ah I think Alex already did this in https://github.com/dotnet/dotnet/pull/7976/changes, so no need for arm64 here |
|
this prob isn't tested in the PR pipeline I imagine? Can we fast merge? |
|
it's possible we'll need something for arm64 too but let's see |
Replaces the stale win-x64 BA2007 baseline records with the exact Windows_x86 records generated by unified build 3032528 for DirectWriteForwarder.dll and System.Printing.dll.