[release/10.0.4xx] Source code updates from nuget/nuget.client - #7337
#7337[release/10.0.4xx] Source code updates from nuget/nuget.client#7337akoeplinger merged 10 commits intorelease/10.0.4xxdotnet/dotnet:release/10.0.4xxfrom darc-release/10.0.4xx-2fb4153d-9a67-4bad-b5b0-aabcb3f96bc8dotnet/dotnet:darc-release/10.0.4xx-2fb4153d-9a67-4bad-b5b0-aabcb3f96bc8Copy head branch name to clipboard
Conversation
[[ commit created by automation ]]
…b5b0-aabcb3f96bc8
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
…a67-4bad-b5b0-aabcb3f96bc8
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
This PR is failing CI with NU1109 errors because NuGet.Packaging 7.9.0-rc.65534 now requires Newtonsoft.Json ≥ 13.0.4, but the SDK’s CPM in The fix would be to bump @dotnet/dotnet-cli — can you confirm it’s safe to bump Newtonsoft.Json from 13.0.3 to 13.0.4 in the SDK for 10.0.4xx? |
|
FWIW, VS ships 13.0.3, and 13.0.4 added new overloads to existing APIs, without bumping the assembly version, causing NuGet to fail. So, we're looking to revert back to 13.0.3: |
|
FWIW, I think we moved most of our VS components off of newtonsoft. I believe Microsoft.NET.Build.Tasks in 10.0.4xx is the main one though that's still on it. Given the comments above, we may need to wait for the nuget update since that would likely affect that task. |
…b5b0-aabcb3f96bc8
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
…b5b0-aabcb3f96bc8
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
|
Bumping NJ would also mean bumping the version in source-build-assets and that needs to be coordinated. I think reverting the bump is the right fix for now for 10.0.4xx |
Note
This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/nuget/nuget.client
Diff the source with this PR branch