Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[release/10.0.4xx] Source code updates from nuget/nuget.client - #7337

#7337
Merged
akoeplinger merged 10 commits into
release/10.0.4xxdotnet/dotnet:release/10.0.4xxfrom
darc-release/10.0.4xx-2fb4153d-9a67-4bad-b5b0-aabcb3f96bc8dotnet/dotnet:darc-release/10.0.4xx-2fb4153d-9a67-4bad-b5b0-aabcb3f96bc8Copy head branch name to clipboard
Jun 29, 2026
Merged

[release/10.0.4xx] Source code updates from nuget/nuget.client#7337
akoeplinger merged 10 commits into
release/10.0.4xxdotnet/dotnet:release/10.0.4xxfrom
darc-release/10.0.4xx-2fb4153d-9a67-4bad-b5b0-aabcb3f96bc8dotnet/dotnet:darc-release/10.0.4xx-2fb4153d-9a67-4bad-b5b0-aabcb3f96bc8Copy head branch name to clipboard

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Note

This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/nuget/nuget.client

Diff the source with this PR branch
darc vmr diff --name-only https://github.com/nuget/nuget.client:cb56946c2b640233513200754ed2948ef0e4880b..https://github.com/dotnet/dotnet:darc-release/10.0.4xx-2fb4153d-9a67-4bad-b5b0-aabcb3f96bc8

@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service
dotnet-policy-service Bot requested a review from a team June 24, 2026 02:10
@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@lewing

lewing commented Jun 26, 2026

Copy link
Copy Markdown
Member

This PR is failing CI with NU1109 errors because NuGet.Packaging 7.9.0-rc.65534 now requires Newtonsoft.Json ≥ 13.0.4, but the SDK’s CPM in src/sdk/eng/Versions.props pins NewtonsoftJsonPackageVersion to 13.0.3.

The fix would be to bump NewtonsoftJsonPackageVersion to 13.0.4 (the current stable release) in this PR so it backflows to the SDK. However, we want to make sure this doesn’t cause issues with VS compatibility.

@dotnet/dotnet-cli — can you confirm it’s safe to bump Newtonsoft.Json from 13.0.3 to 13.0.4 in the SDK for 10.0.4xx?

@zivkan

zivkan commented Jun 26, 2026

Copy link
Copy Markdown
Member

FWIW, VS ships 13.0.3, and 13.0.4 added new overloads to existing APIs, without bumping the assembly version, causing NuGet to fail. So, we're looking to revert back to 13.0.3:

@marcpopMSFT

Copy link
Copy Markdown
Member

FWIW, I think we moved most of our VS components off of newtonsoft. I believe Microsoft.NET.Build.Tasks in 10.0.4xx is the main one though that's still on it. Given the comments above, we may need to wait for the nuget update since that would likely affect that task.

@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@akoeplinger

akoeplinger commented Jun 29, 2026

Copy link
Copy Markdown
Member

Bumping NJ would also mean bumping the version in source-build-assets and that needs to be coordinated. I think reverting the bump is the right fix for now for 10.0.4xx

@akoeplinger
akoeplinger merged commit 06b6ec8 into release/10.0.4xx Jun 29, 2026
13 checks passed
@akoeplinger
akoeplinger deleted the darc-release/10.0.4xx-2fb4153d-9a67-4bad-b5b0-aabcb3f96bc8 branch June 29, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.