Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[main] Source code updates from dotnet/msbuild - #6604

#6604
Merged
dotnet-maestro[bot] merged 4 commits into
maindotnet/dotnet:mainfrom
darc-main-4bbe6a88-7d71-4dcb-b9e8-a5d90ee8b497dotnet/dotnet:darc-main-4bbe6a88-7d71-4dcb-b9e8-a5d90ee8b497Copy head branch name to clipboard
May 15, 2026
Merged

[main] Source code updates from dotnet/msbuild#6604
dotnet-maestro[bot] merged 4 commits into
maindotnet/dotnet:mainfrom
darc-main-4bbe6a88-7d71-4dcb-b9e8-a5d90ee8b497dotnet/dotnet:darc-main-4bbe6a88-7d71-4dcb-b9e8-a5d90ee8b497Copy head branch name to clipboard

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Note

This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/msbuild

Diff the source with this PR branch
darc vmr diff --name-only https://github.com/dotnet/msbuild:2aa10e5e513d946d543443ee2769f95f0261ecb6..https://github.com/dotnet/dotnet:darc-main-4bbe6a88-7d71-4dcb-b9e8-a5d90ee8b497

@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

@OvesN
OvesN requested a review from ViktorHofer May 14, 2026 16:23
@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

@ViktorHofer

Copy link
Copy Markdown
Member

Should we update msbuild to xunit v4 in a follow-up and remove this special casing?

@OvesN

OvesN commented May 15, 2026

Copy link
Copy Markdown
Contributor

Should we update msbuild to xunit v4 in a follow-up and remove this special casing?

@ViktorHofer
I discussed it with @JanProvaznik. And we think that this is not necessary now.

@dotnet-maestro
dotnet-maestro Bot merged commit 445a6db into main May 15, 2026
16 checks passed
@dotnet-maestro
dotnet-maestro Bot deleted the darc-main-4bbe6a88-7d71-4dcb-b9e8-a5d90ee8b497 branch May 15, 2026 08:50
@dotnet-policy-service
dotnet-policy-service Bot requested a review from a team May 15, 2026 08:51
OvesN added a commit to dotnet/msbuild that referenced this pull request May 19, 2026
Changes from dotnet/dotnet#6604.
We need to push it to msbuild main in order to it to flow to release and
main branch in VMR.

Difference: now i check that XUnit version is equals or greater than 4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.