Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Use source-build-assets repo - #6044

#6044
Merged
NikolaMilosavljevic merged 10 commits into
dotnet:maindotnet/dotnet:mainfrom
NikolaMilosavljevic:sbrp.mainNikolaMilosavljevic/dotnet:sbrp.mainCopy head branch name to clipboard
Apr 17, 2026
Merged

Use source-build-assets repo#6044
NikolaMilosavljevic merged 10 commits into
dotnet:maindotnet/dotnet:mainfrom
NikolaMilosavljevic:sbrp.mainNikolaMilosavljevic/dotnet:sbrp.mainCopy head branch name to clipboard

Conversation

@NikolaMilosavljevic

@NikolaMilosavljevic NikolaMilosavljevic commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

After source-build-reference-packages repo was renamed to source-build-assets, changes are needed in VMR to allow proper consumption and flow.

This PR updates repo-related properties or values, as well as various other references in code and documentation. If something is not renamed, I'd prefer to prepare a follow up change in a new PR, to not delay this work any longer, considering timelines for next preview release and code-complete date.

Validation

VMR build

Copilot AI review requested due to automatic review settings April 15, 2026 15:34
@NikolaMilosavljevic
NikolaMilosavljevic requested review from a team as code owners April 15, 2026 15:34
Copilot AI reviewed Apr 15, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the VMR to consume the renamed dotnet/source-build-assets repository by replacing source-build-reference-packages / “SBRP” references across build logic, tooling, and documentation.

Changes:

  • Renames repo references (paths, repo names, and feed/source names) from SBRP to SBA across VMR build orchestration.
  • Updates MSBuild tasks and build props/targets to use the new repo name and source paths.
  • Refreshes documentation links and guidance to point to dotnet/source-build-assets.

Reviewed changes

Copilot reviewed 50 out of 10397 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/source-build-assets/src/externalPackages/projects/Directory.Build.targets Renames NuGet source/comment from SBRP to SBA within source-build-assets build targets.
src/source-build-assets/azure-pipelines/builds/cleanup-unreferenced-packages.yml Updates pipeline repo name and path trimming to source-build-assets.
src/source-build-assets/README.md Updates repo links/name references to source-build-assets.
src/source-build-assets/.devcontainer/init.sh Updates expected workspace folder name for the repo.
src/source-build-assets/.devcontainer/init-toolset.sh Updates default workspace path to source-build-assets.
src/source-build-assets/.config/tsaoptions.json Updates TSA repo/codebase names to source-build-assets.
src/sdk/src/Tasks/Microsoft.NET.Build.Extensions.Tasks/Microsoft.NET.Build.Extensions.Tasks.csproj Updates comment to reference SBA-produced version.
src/sdk/src/Cli/dotnet/dotnet.csproj Updates comment to reference SBA-produced version.
src/sdk/eng/Versions.props Updates comments/links to new repo for text-only packages guidance.
src/sdk/eng/Version.Details.xml Updates comment references from SBRP to SBA.
src/razor/eng/Version.Details.xml Updates comment references from SBRP to SBA.
src/msbuild/eng/dependabot/Directory.Packages.props Updates comment link to new repo path.
src/msbuild/eng/Versions.props Updates comment guidance to add versions to source-build-assets.
src/msbuild/documentation/specs/proposed/interactive-package-references.md Updates documentation link to externalPackages in source-build-assets.
src/arcade/Documentation/update-xunit.md Updates docs to point to new repo (partially).
src/arcade/Documentation/V3StatusUpdate.md Renames repo row to source-build-assets.
src/arcade/Documentation/SBOMGenerationGuidance.md Updates repo list entry to source-build-assets.
repo-projects/vstest.proj Switches repository reference to source-build-assets.
repo-projects/templating.proj Switches repository reference to source-build-assets.
repo-projects/symreader.proj Switches repository reference to source-build-assets.
repo-projects/sourcelink.proj Switches repository reference to source-build-assets.
repo-projects/sdk.proj Switches repository reference to source-build-assets (and normalizes BOM/format).
repo-projects/runtime.proj Switches repository reference to source-build-assets.
repo-projects/roslyn.proj Switches repository reference to source-build-assets.
repo-projects/razor.proj Switches repository reference to source-build-assets.
repo-projects/nuget-client.proj Switches repository reference to source-build-assets.
repo-projects/msbuild.proj Switches repository reference to source-build-assets.
repo-projects/fsharp.proj Switches repository reference to source-build-assets.
repo-projects/emsdk.proj Switches repository reference to source-build-assets.
repo-projects/diagnostics.proj Switches repository reference to source-build-assets.
repo-projects/deployment-tools.proj Switches repository reference to source-build-assets.
repo-projects/command-line-api.proj Switches repository reference to source-build-assets.
repo-projects/cecil.proj Switches repository reference to source-build-assets.
repo-projects/aspnetcore.proj Switches repository reference to source-build-assets.
repo-projects/arcade.proj Switches repository reference to source-build-assets.
repo-projects/Directory.Build.targets Renames task parameters/metadata from SBRP to SBA and updates repo-name conditions.
repo-projects/Directory.Build.props Updates cache feed value to source-build-assets-cache (property name not updated).
eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/WriteSbrpUsageReport.cs Renames internal logic/output to SBA while keeping task/type name.
eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/WritePackageVersionsProps.cs Updates comment to reference source-build-assets.
eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/UpdateNuGetConfigPackageSourcesMappings.cs Renames task parameters/logic from SBRP cache discovery to SBA.
eng/finish-source-only.proj Updates task invocation arguments to SBA paths.
eng/allowed-vmr-binaries.txt Updates allow-list paths for moved repo directory.
eng/allowed-sb-binaries.txt Updates allow-list paths for moved repo directory.
eng/VmrLayout.props Replaces SbrpRepoSrcDir with SourceBuildAssetsRepoSrcDir.
eng/PublishSourceBuild.props Renames item group for poison checking from SBRP to SBA.
docs/VMR-Strategy-For-External-Source.md Updates strategy doc references/links to source-build-assets.
docs/VMR-Design-And-Operation.md Updates VMR layout docs to src/source-build-assets/.
docs/TFM-Trimming-And-Targeting.md Updates link to new repo.
Directory.Build.props Updates BootstrapArcadeRepos to use source-build-assets.
.config/CredScanSuppressions.json Updates suppression paths to new repo directory.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread repo-projects/Directory.Build.props Outdated
Comment thread src/arcade/Documentation/update-xunit.md
Comment thread eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/UpdateNuGetConfigPackageSourcesMappings.cs
Comment thread src/source-build-assets/README.md
Comment thread src/msbuild/documentation/specs/proposed/interactive-package-references.md
@dotnet-policy-service
dotnet-policy-service Bot requested review from a team April 15, 2026 15:55
@NikolaMilosavljevic NikolaMilosavljevic mentioned this pull request Apr 15, 2026
Merged
@NikolaMilosavljevic

NikolaMilosavljevic commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

Hmm, more conflicts, as old SBRP path was updated with a new repo flow...

Will rebase/resolve offline and force-push.

@NikolaMilosavljevic

NikolaMilosavljevic commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

Hmm, more conflicts, as old SBRP path was updated with a new repo flow...

Will rebase/resolve offline and force-push.

It would be good to merge this PR soon, i.e. today. @mthalman @ellahathaway @marcpopMSFT @premun - fyi

@premun

premun commented Apr 17, 2026

Copy link
Copy Markdown
Member

@NikolaMilosavljevic I approved so feel free to merge. Someone will have to bypass the merge policies when the build is green again (you might need to JIT for that? I saw @mthalman doing that yesterday so when you are both around, go ahead).

@premun

premun commented Apr 17, 2026

Copy link
Copy Markdown
Member

In the meantime, I'd suggest putting blocking reviews on SBRP FFs

@NikolaMilosavljevic
NikolaMilosavljevic merged commit 54d43b1 into dotnet:main Apr 17, 2026
8 of 11 checks passed
@ellahathaway ellahathaway mentioned this pull request Apr 20, 2026
Merged
@adamzip adamzip mentioned this pull request Apr 21, 2026
Open
@shreyarao4 shreyarao4 mentioned this pull request Jun 12, 2026
Merged
saitama951 pushed a commit to IBM/dotnet-s390x that referenced this pull request Jun 12, 2026
@shreyarao4 @saitama951
Backporting fix for soure-build directory change
b4ac4f0 
Newer SDK versions contain a repository layout change after source-build-reference-packages repo was renamed to source-build-assets
As a result, cherry-picking e64f84d fails with a file-location conflict
PR:dotnet/dotnet#6044

This PR  resolves the e64f84d backport conflict caused by this migration by automatically staging the relocated patch file and continuing the cherry-pick. This remove manual conflict resolution.

Signed-off-by: shreya <raoshreya412@gmail.com>
@dotnet-maestro dotnet-maestro Bot mentioned this pull request Jul 1, 2026
Merged
shreyarao4 added a commit to shreyarao4/dotnet-s390x that referenced this pull request Jul 9, 2026
@shreyarao4
Backporting fix for soure-build directory change
1c3be37 
Newer SDK versions contain a repository layout change after source-build-reference-packages repo was renamed to source-build-assets
As a result, cherry-picking e64f84d fails with a file-location conflict
PR:dotnet/dotnet#6044

This PR  resolves the e64f84d backport conflict caused by this migration by automatically staging the relocated patch file and continuing the cherry-pick. This remove manual conflict resolution.

Signed-off-by: shreya <raoshreya412@gmail.com>
Signed-off-by: Shreya Rao <raoshreya412@gmail.com>
shreyarao4 added a commit to shreyarao4/dotnet-s390x that referenced this pull request Jul 9, 2026
@shreyarao4
Backporting fix for soure-build directory change
0d19029 
Newer SDK versions contain a repository layout change after source-build-reference-packages repo was renamed to source-build-assets
As a result, cherry-picking e64f84d fails with a file-location conflict
PR:dotnet/dotnet#6044

This PR  resolves the e64f84d backport conflict caused by this migration by automatically staging the relocated patch file and continuing the cherry-pick. This remove manual conflict resolution.

Signed-off-by: shreya <raoshreya412@gmail.com>
Signed-off-by: Shreya Rao <raoshreya412@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@mthalman mthalman mthalman approved these changes
@premun premun Awaiting requested review from premun
@dkurepa dkurepa Awaiting requested review from dkurepa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NikolaMilosavljevic @premun @mthalman
Morty Proxy This is a proxified and sanitized view of the page, visit original site.