Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[release/10.0.1xx] Source code updates from dotnet/runtime - #3756

#3756
Merged
mmitche merged 8 commits into
release/10.0.1xxdotnet/dotnet:release/10.0.1xxfrom
darc-release/10.0.1xx-24f5884e-03bb-47ef-b395-bbdf5f44f341dotnet/dotnet:darc-release/10.0.1xx-24f5884e-03bb-47ef-b395-bbdf5f44f341Copy head branch name to clipboard
Dec 11, 2025
Merged

[release/10.0.1xx] Source code updates from dotnet/runtime#3756
mmitche merged 8 commits into
release/10.0.1xxdotnet/dotnet:release/10.0.1xxfrom
darc-release/10.0.1xx-24f5884e-03bb-47ef-b395-bbdf5f44f341dotnet/dotnet:darc-release/10.0.1xx-24f5884e-03bb-47ef-b395-bbdf5f44f341Copy head branch name to clipboard

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

Note

This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/runtime

Diff the source with this PR branch
darc vmr diff --name-only https://github.com/dotnet/runtime:0b4a62d8efc9e751b763a1eefc1a9d37503e1a72..https://github.com/dotnet/dotnet:darc-release/10.0.1xx-24f5884e-03bb-47ef-b395-bbdf5f44f341

@dotnet-policy-service
dotnet-policy-service Bot requested a review from a team December 9, 2025 22:10
@dotnet-maestro

dotnet-maestro Bot commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

dotnet-maestro Bot commented Dec 9, 2025

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

Important

The source repository has received code changes from an opposite flow. Any additional codeflows into this PR may potentially result in lost changes.

Please continue with one of the following options:

  1. Close or merge this PR and let the codeflow continue normally
  2. Close or merge this PR and receive the new codeflow immediately by triggering the subscription:
    darc trigger-subscriptions --id 97d3bf62-2885-49c1-87fe-a1f23e25ce08
  3. Force-flow new changes into this PR at your own risk (some PR commits might be reverted):
    darc trigger-subscriptions --force --id 97d3bf62-2885-49c1-87fe-a1f23e25ce08

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@mmitche

mmitche commented Dec 10, 2025

Copy link
Copy Markdown
Member

@akoeplinger The failure here is due to NuGet.config not getting updated in this forward flow. The offending dependency lives on darc-pub-dotnet-dotnet-02dfa783

@mmitche

mmitche commented Dec 10, 2025

Copy link
Copy Markdown
Member

@premun @dkurepa Any idea why the stable feeds in nuget.config wouldn't get propagated here on forward flow?

@mmitche

mmitche commented Dec 10, 2025

Copy link
Copy Markdown
Member

Note that this bug wouldn't show up in newer builds of the VMR. It's caused by the codeanalysis packages erroneously getting sent to stable feeds

Updated the NuGet package source URL for 'darc-pub-dotnet-dotnet' and removed the 'general-testing' package source.
@mmitche
mmitche enabled auto-merge (squash) December 10, 2025 19:31
@mmitche
mmitche merged commit 4c5e9ff into release/10.0.1xx Dec 11, 2025
15 of 16 checks passed
@mmitche
mmitche deleted the darc-release/10.0.1xx-24f5884e-03bb-47ef-b395-bbdf5f44f341 branch December 11, 2025 01:47
@premun

premun commented Dec 11, 2025

Copy link
Copy Markdown
Member

@mmitche we don't do anything special on FF with feeds.

@premun

premun commented Dec 11, 2025

Copy link
Copy Markdown
Member

@mmitche should we run the feed clean up that is based on V.D.xml everytime after a BF/FF?

@mmitche

mmitche commented Dec 11, 2025

Copy link
Copy Markdown
Member

@mmitche should we run the feed clean up that is based on V.D.xml everytime after a BF/FF?

Yes...though maybe not needed for FF since the nuget config would just come in from the repo. It also looks like it's happening on BF when packages are updated at least. It should happen always though.

That might be related to this: dotnet/arcade-services#5623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.