Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[release/10.0.1xx] Source code updates from nuget/nuget.client - #2126

#2126
Merged
zivkan merged 5 commits into
release/10.0.1xxdotnet/dotnet:release/10.0.1xxfrom
darc-release/10.0.1xx-76e2ebd4-4ba2-4068-a6f2-61bc1f6bf541dotnet/dotnet:darc-release/10.0.1xx-76e2ebd4-4ba2-4068-a6f2-61bc1f6bf541Copy head branch name to clipboard
Aug 27, 2025
Merged

[release/10.0.1xx] Source code updates from nuget/nuget.client#2126
zivkan merged 5 commits into
release/10.0.1xxdotnet/dotnet:release/10.0.1xxfrom
darc-release/10.0.1xx-76e2ebd4-4ba2-4068-a6f2-61bc1f6bf541dotnet/dotnet:darc-release/10.0.1xx-76e2ebd4-4ba2-4068-a6f2-61bc1f6bf541Copy head branch name to clipboard

Conversation

@dotnet-maestro

Copy link
Copy Markdown
Contributor

Note

This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/nuget/nuget.client

@zivkan

zivkan commented Aug 26, 2025

Copy link
Copy Markdown
Member

If the build fails, then it needs the changes to src/Layout/redist/targets/BundledSdks.targets, src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj, and src/Tasks/Microsoft.NET.Build.Tasks/sdk/Sdk.targets from dotnet/sdk@main...zivkan:sdk:update-pack-tasks-layout

I tried to check out this dotnet/dotnet repo so I could commit the changes directly into this PR's branch, but git is telling me some paths are too long, despite having enabled long path support in windows 🤷

If the build doesn't fail, the dotnet pack command will certainly be broken, but I can fix that once this flows back to dotnet/sdk, and I don't have a problem cloning that repo.

@akoeplinger

Copy link
Copy Markdown
Member

I tried to check out this dotnet/dotnet repo so I could commit the changes directly into this PR's branch, but git is telling me some paths are too long, despite having enabled long path support in windows 🤷

@zivkan make sure you enable long path support in git as well: https://github.com/dotnet/dotnet#prerequisites

@akoeplinger

akoeplinger commented Aug 26, 2025

Copy link
Copy Markdown
Member

I cherry-picked the changes locally but it'll be easier if we wait for #2128 to merge first

@akoeplinger

Copy link
Copy Markdown
Member

@zivkan I pushed your changes but the source-only build is still failing with:

src/sdk/src/Layout/redist/targets/Crossgen.targets(144,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Potentially missed crossgen for '/__w/1/s/src/sdk/artifacts/bin/redist/Release/dotnet-installer/sdk/10.0.100-ci/Sdks/NuGet.Build.Tasks.Pack/CoreCLR/', directory does not exist

Comment thread src/sdk/src/Layout/redist/targets/Crossgen.targets
@zivkan
zivkan merged commit f1bee17 into release/10.0.1xx Aug 27, 2025
15 checks passed
@zivkan
zivkan deleted the darc-release/10.0.1xx-76e2ebd4-4ba2-4068-a6f2-61bc1f6bf541 branch August 27, 2025 21:48
@ViktorHofer
ViktorHofer restored the darc-release/10.0.1xx-76e2ebd4-4ba2-4068-a6f2-61bc1f6bf541 branch December 9, 2025 13:34
@ViktorHofer
ViktorHofer deleted the darc-release/10.0.1xx-76e2ebd4-4ba2-4068-a6f2-61bc1f6bf541 branch December 9, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.