Fix CancellationTokenMultiplexer return to pool#272
Merged
sakno merged 1 commit intoSep 28, 2025
dotnet:developdotnet/dotNext:developfrom
timothycoleman:fix-cancellation-token-multiplexer-poolingtimothycoleman/dotNext:fix-cancellation-token-multiplexer-poolingCopy head branch name to clipboard
Merged
Fix CancellationTokenMultiplexer return to pool#272sakno merged 1 commit intodotnet:developdotnet/dotNext:developfrom timothycoleman:fix-cancellation-token-multiplexer-poolingtimothycoleman/dotNext:fix-cancellation-token-multiplexer-poolingCopy head branch name to clipboard
sakno merged 1 commit into
dotnet:developdotnet/dotNext:developfrom
timothycoleman:fix-cancellation-token-multiplexer-poolingtimothycoleman/dotNext:fix-cancellation-token-multiplexer-poolingCopy head branch name to clipboard
Conversation
Fixes a operator precedence bug and adds tests. If the PooledCancellationTokenSource had inlined tokens but no extraTokens, the Count would evaluate to 0 which would prevent the CancellationTokenRegistrations from being disposed. The PooledCancellationTokenSource would then be returned to the pool but still be cancelable by the tokens which were preivously attached.
Contributor
Author
|
@dotnet-policy-service agree |
timothycoleman
deleted the
fix-cancellation-token-multiplexer-pooling
branch
September 29, 2025 08:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a operator precedence bug and adds tests.
If the PooledCancellationTokenSource had inlined tokens but no extraTokens, the Count would evaluate to 0 which would prevent the CancellationTokenRegistrations from being disposed.
The PooledCancellationTokenSource would then be returned to the pool but still be cancelable by the tokens which were previously attached.