This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Align f# web templates (preview2) - #4985
#4985Merged
TheRealPiotrP merged 1 commit intoDec 10, 2016
dotnet:rel/1.0.0-preview2dotnet/cli:rel/1.0.0-preview2from
enricosada:align_fsharp_templates_p2_webenricosada/cli:align_fsharp_templates_p2_webCopy head branch name to clipboard
Merged
Align f# web templates (preview2)#4985TheRealPiotrP merged 1 commit intodotnet:rel/1.0.0-preview2dotnet/cli:rel/1.0.0-preview2from enricosada:align_fsharp_templates_p2_webenricosada/cli:align_fsharp_templates_p2_webCopy head branch name to clipboard
TheRealPiotrP merged 1 commit into
dotnet:rel/1.0.0-preview2dotnet/cli:rel/1.0.0-preview2from
enricosada:align_fsharp_templates_p2_webenricosada/cli:align_fsharp_templates_p2_webCopy head branch name to clipboard
Conversation
|
@enricosada Please tag me again once @piotrpMSFT @livarcocc have signed off (I need to be the final signoff, and I have inbox rules that filter everything out unless I am specifically tagged again.) All -- please note that this would be for RC3 alignment not RC2 alignment -- RC2 is now at "recall class." |
TheRealPiotrP
left a comment
There was a problem hiding this comment.
This looks good to me, but I'd actually like @mlorbetske to sign off as I'm not familiar with ASP.NET dependencies.
Author
|
Adding the online diff If needed http://www.mergely.com/ESFER5l6/ |
mlorbetske
approved these changes
Dec 9, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aligned F# web templates after PR #4980 changed the c# one.
just package version changes
Affect preview2
@piotrpMSFT @MattGertz @livarcocc for approval for merge in next preview2 🙏 😄