[release/8.0] Backport docker image fix - #67279
#67279Merged
wtgodbe merged 1 commit intoJun 17, 2026
dotnet:release/8.0dotnet/aspnetcore:release/8.0from
wtgodbe:backport/docker-containers-8.0wtgodbe/aspnetcore:backport/docker-containers-8.0Copy head branch name to clipboard
Merged
[release/8.0] Backport docker image fix#67279wtgodbe merged 1 commit intodotnet:release/8.0dotnet/aspnetcore:release/8.0from wtgodbe:backport/docker-containers-8.0wtgodbe/aspnetcore:backport/docker-containers-8.0Copy head branch name to clipboard
wtgodbe merged 1 commit into
dotnet:release/8.0dotnet/aspnetcore:release/8.0from
wtgodbe:backport/docker-containers-8.0wtgodbe/aspnetcore:backport/docker-containers-8.0Copy head branch name to clipboard
Conversation
Use prebuilt MCR containers for Debian/RPM package builds instead of inline docker builds to avoid network isolation issues. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wtgodbe
force-pushed
the
backport/docker-containers-8.0
branch
from
June 17, 2026 19:06
9a46d78 to
a425b80
Compare
mmitche
approved these changes
Jun 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the release/8.0 CI pipeline to build Linux DEB/RPM installers inside prebuilt MCR container images (instead of relying on dockerbuild.sh), aiming to avoid network isolation issues during package builds.
Changes:
- Add DEB/RPM container resources and run the installer build steps inside those containers.
- Bump Debian packaging debhelper compatibility level from 9 to 10.
- Add
pkg-version.tsfiles for the SignalR TS packages (but the hard-coded version currently appears inconsistent with the package versions and existing version-stamping flow).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/SignalR/clients/ts/signalr/src/pkg-version.ts | Adds a VERSION constant file; current value is inconsistent with package versioning/stamping approach. |
| src/SignalR/clients/ts/signalr-protocol-msgpack/src/pkg-version.ts | Adds a VERSION constant file; current value is inconsistent with package versioning/stamping approach. |
| src/Installers/Debian/tools/package_files/debian/compat | Updates debhelper compat level used for Debian packaging. |
| .azure/pipelines/ci.yml | Switches Linux installer builds to run in prebuilt container images; replaces dockerbuild.sh usage and adds container resources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+384
to
+395
| - script: ./eng/build.sh | ||
| --ci | ||
| --nobl | ||
| --arch x64 | ||
| --build-installers | ||
| --no-build-deps | ||
| --no-build-nodejs | ||
| -p:OnlyPackPlatformSpecificPackages=true | ||
| -p:BuildRuntimeArchive=false | ||
| -p:LinuxInstallerType=deb | ||
| $(_BuildArgs) | ||
| $(_InternalRuntimeDownloadArgs) |
Comment on lines
+398
to
+411
| - script: ./eng/build.sh | ||
| --ci | ||
| --nobl | ||
| --arch x64 | ||
| --build-installers | ||
| --no-build-deps | ||
| --no-build-nodejs | ||
| -p:OnlyPackPlatformSpecificPackages=true | ||
| -p:BuildRuntimeArchive=false | ||
| -p:LinuxInstallerType=rpm | ||
| -p:AssetManifestFileName=aspnetcore-Linux_x64.xml | ||
| $(_BuildArgs) | ||
| $(_PublishArgs) | ||
| $(_InternalRuntimeDownloadArgs) |
Comment on lines
+477
to
+490
| - script: ./eng/build.sh | ||
| --ci | ||
| --nobl | ||
| --arch arm64 | ||
| --build-installers | ||
| --no-build-deps | ||
| --no-build-nodejs | ||
| -p:OnlyPackPlatformSpecificPackages=true | ||
| -p:BuildRuntimeArchive=false | ||
| -p:LinuxInstallerType=rpm | ||
| -p:AssetManifestFileName=aspnetcore-Linux_arm64.xml | ||
| $(_BuildArgs) | ||
| $(_PublishArgs) | ||
| $(_InternalRuntimeDownloadArgs) |
vseanreesermsft
approved these changes
Jun 17, 2026
This was referenced Jul 14, 2026
Closed
Closed
This was referenced Jul 27, 2026
Closed
Merged
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use prebuilt MCR containers for Linux package builds to avoid network isolation issues.