Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update azure/msal-browser #66055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtgodbe merged 1 commit into from
Mar 31, 2026
Merged

Update azure/msal-browser #66055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions 16 package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion 7 src/Components/WebAssembly/Authentication.Msal/src/Interop/AuthenticationService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,10 @@ class MsalAuthorizeService implements AuthorizeService {
this._msalApplication = new Msal.PublicClientApplication(this._settings);
}

async initialize(): Promise<void> {
await this._msalApplication.initialize();
}

getAccount() {
if (this._account) {
return this._account;
Expand Down Expand Up @@ -283,7 +287,7 @@ class MsalAuthorizeService implements AuthorizeService {
return await this._msalApplication.loginPopup(request);
} catch (e) {
// If the user explicitly cancelled the pop-up, avoid performing a redirect.
if (this.isMsalError(e) && e.errorCode !== Msal.BrowserAuthErrorMessage.userCancelledError.code) {
if (this.isMsalError(e) && e.errorCode !== Msal.BrowserAuthErrorCodes.userCancelled) {
this.debug('User canceled sign-in pop-up');
this.signInWithRedirect(request);
Comment on lines 289 to 292

Copilot AI Mar 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition here triggers the redirect fallback when the error is not userCancelled, but the log message says the user canceled. This is misleading for diagnostics; consider updating the message to reflect a non-cancel popup failure (e.g., popup blocked) that is causing the redirect fallback.

Copilot uses AI. Check for mistakes.
} else {
Expand Down Expand Up @@ -466,6 +470,7 @@ export class AuthenticationService {
public static async init(settings: AuthorizeServiceConfiguration, jsLoggingOptions: JavaScriptLoggingOptions) {
if (!AuthenticationService._initialized) {
AuthenticationService.instance = new MsalAuthorizeService(settings, new Logger(jsLoggingOptions));
await AuthenticationService.instance.initialize();
AuthenticationService.instance.initializeMsalHandler();
AuthenticationService._initialized = true;
}
Expand Down
2 changes: 1 addition & 1 deletion 2 src/Components/WebAssembly/Authentication.Msal/src/Interop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
"build:production": "rollup -c --environment production --forceExit"
},
"dependencies": {
"@azure/msal-browser": "^2.28.3"
"@azure/msal-browser": "^4.30.0"
}
}
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.