Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Upload binlogs for Helix SharedFx build step - #65102

#65102
Merged
wtgodbe merged 1 commit into
maindotnet/aspnetcore:mainfrom
wtgodbe/HelixBinlogdotnet/aspnetcore:wtgodbe/HelixBinlogCopy head branch name to clipboard
Jan 16, 2026
Merged

Upload binlogs for Helix SharedFx build step#65102
wtgodbe merged 1 commit into
maindotnet/aspnetcore:mainfrom
wtgodbe/HelixBinlogdotnet/aspnetcore:wtgodbe/HelixBinlogCopy head branch name to clipboard

Conversation

@wtgodbe

@wtgodbe wtgodbe commented Jan 16, 2026

Copy link
Copy Markdown
Member

No description provided.

@wtgodbe
wtgodbe requested a review from a team as a code owner January 16, 2026 16:11
Copilot AI review requested due to automatic review settings January 16, 2026 16:11
@github-actions github-actions Bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables binary logging (binlog) for the Helix SharedFx build steps in the CI pipelines. The changes add two new binlog variables and remove the -nobl flag from the Helix build commands, allowing MSBuild to generate diagnostic binlogs that will be published as pipeline artifacts.

Changes:

  • Added HelixSubset1LogArgs and HelixSubset2LogArgs variables to define binlog paths for the two Helix subset jobs
  • Removed the -nobl flag from Helix SharedFx build commands to enable binlog generation
  • Applied the new binlog arguments to Helix build scripts in both ci.yml and ci-public.yml

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.azure/pipelines/ci.yml Added Helix binlog variables and updated two Helix subset build commands to use binlog arguments instead of -nobl
.azure/pipelines/ci-public.yml Added Helix binlog variables and updated two Helix subset build commands to use binlog arguments instead of -nobl

@wtgodbe
wtgodbe merged commit 2a88012 into main Jan 16, 2026
29 of 32 checks passed
@wtgodbe
wtgodbe deleted the wtgodbe/HelixBinlog branch January 16, 2026 17:51
@dotnet-policy-service dotnet-policy-service Bot added this to the 11.0-preview1 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.