Mark productVersion.txt as shipping artifact in 8.0 - #64067
#64067Merged
mmitche merged 2 commits intoOct 15, 2025
release/8.0dotnet/aspnetcore:release/8.0from
copilot/fix-productversion-txt-shippingdotnet/aspnetcore:copilot/fix-productversion-txt-shippingCopy head branch name to clipboard
Merged
Mark productVersion.txt as shipping artifact in 8.0#64067mmitche merged 2 commits intorelease/8.0dotnet/aspnetcore:release/8.0from copilot/fix-productversion-txt-shippingdotnet/aspnetcore:copilot/fix-productversion-txt-shippingCopy head branch name to clipboard
mmitche merged 2 commits into
release/8.0dotnet/aspnetcore:release/8.0from
copilot/fix-productversion-txt-shippingdotnet/aspnetcore:copilot/fix-productversion-txt-shippingCopy head branch name to clipboard
Conversation
Co-authored-by: mmitche <8725170+mmitche@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix productVersion.txt to be marked as shipping
Mark productVersion.txt as shipping artifact in 8.0
Oct 15, 2025
mmitche
approved these changes
Oct 15, 2025
wtgodbe
approved these changes
Oct 15, 2025
mmitche
marked this pull request as ready for review
October 15, 2025 22:49
mmitche
enabled auto-merge (squash)
October 15, 2025 22:49
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR corrects the shipping artifact classification for version files in the ASP.NET Core 8.0 build configuration. The productVersion.txt and aspnetcore-productVersion.txt files were incorrectly marked as non-shipping artifacts, which would prevent them from being published to their expected CDN locations.
Key Changes:
- Updated
ManifestArtifactDataproperty fromNonShipping=truetoNonShipping=falsefor both version files
This was referenced Nov 11, 2025
This was referenced Jul 17, 2026
Open
Closed
Closed
Closed
This was referenced Jul 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue where
productVersion.txtandaspnetcore-productVersion.txtwere incorrectly marked as non-shipping artifacts in the ASP.NET Core 8.0 build configuration. These files are required in the final CDN locations and must be marked as shipping artifacts.Changes
Modified
eng/Publishing.propsto change theManifestArtifactDataproperty fromNonShipping=truetoNonShipping=falsefor both:productVersion.txtaspnetcore-productVersion.txtThis ensures these version files are properly included in the shipping manifest and published to the correct CDN locations alongside other shipping artifacts.
Impact
Without this change, the productVersion.txt files would not be available in the expected CDN locations, which could impact downstream consumers that rely on these files to determine the ASP.NET Core runtime version.
Fixes #[issue_number]
Original prompt
Fixes #64066
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.