Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Enable PublishReadyToRun on LA64 and RV64 - #61855

#61855
Merged
wtgodbe merged 3 commits into
dotnet:maindotnet/aspnetcore:mainfrom
am11:patch-1am11/aspnetcore:patch-1Copy head branch name to clipboard
May 9, 2025
Merged

Enable PublishReadyToRun on LA64 and RV64#61855
wtgodbe merged 3 commits into
dotnet:maindotnet/aspnetcore:mainfrom
am11:patch-1am11/aspnetcore:patch-1Copy head branch name to clipboard

Conversation

@am11

@am11 am11 commented May 9, 2025

Copy link
Copy Markdown
Member

Potentially reverting #60336, since we are using host crossgen2 during the cross build.

Tested with VMR: https://github.com/am11/dotnet-riscv/actions/runs/14934033078

@github-actions github-actions Bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 9, 2025
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label May 9, 2025
@am11

am11 commented May 9, 2025

Copy link
Copy Markdown
Member Author

cc @akoeplinger, @jkoritzinsky part 2 of dotnet/runtime#115423.

Comment thread src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj Outdated
@akoeplinger
akoeplinger enabled auto-merge (squash) May 9, 2025 18:27
@wtgodbe

wtgodbe commented May 9, 2025

Copy link
Copy Markdown
Member

components-e2e failure is unrelated, let me know if you want me to force-merge (the team that owns that is in Europe, so it's already their weekend)

@am11

am11 commented May 9, 2025

Copy link
Copy Markdown
Member Author

We can merge it as it's an non-disruptive. loongarch64 and riscv64 builds are only validated in runtime repo's CI, and tests are run on QEMU in GitHub actions https://github.com/am11/CrossRepoCITesting or on devices locally.


To protect this good state, I am planning to add two VMR CI build validation legs in dotnet/dotnet repo; freebsd-x64 and linux-riscv64, to cover this gap:

  1. non-MSFT supported, community, OS (freebsd) and arch (riscv64); validating that there was no accidental runtime nuget package dependency.
  2. cross build + source-build.

When we get runtime building with freebsd-riscv64, we can fold into one CI leg (covers both cross-OS && cross-Arch in one go).

@wtgodbe
wtgodbe disabled auto-merge May 9, 2025 20:56
@wtgodbe
wtgodbe merged commit c7415ff into dotnet:main May 9, 2025
@dotnet-policy-service dotnet-policy-service Bot added this to the 10.0-preview5 milestone May 9, 2025
@am11
am11 deleted the patch-1 branch May 9, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.