Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[release/9.0] Pin to S.T.J 8.0.5 in Analyzers - #59776

#59776
Closed
wtgodbe wants to merge 2 commits into
release/9.0dotnet/aspnetcore:release/9.0from
wtgodbe/STJ90dotnet/aspnetcore:wtgodbe/STJ90Copy head branch name to clipboard
Closed

[release/9.0] Pin to S.T.J 8.0.5 in Analyzers#59776
wtgodbe wants to merge 2 commits into
release/9.0dotnet/aspnetcore:release/9.0from
wtgodbe/STJ90dotnet/aspnetcore:wtgodbe/STJ90Copy head branch name to clipboard

Conversation

@wtgodbe

@wtgodbe wtgodbe commented Jan 8, 2025

Copy link
Copy Markdown
Member

Fixes a CG alert. Roslyn isn't going to update to 8.0.5, so we should pin instead

@wtgodbe
wtgodbe requested a review from a team as a code owner January 8, 2025 18:11
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 8, 2025
@dotnet-policy-service dotnet-policy-service Bot added this to the 9.0.x milestone Jan 8, 2025
@wtgodbe

wtgodbe commented Jan 8, 2025

Copy link
Copy Markdown
Member Author

/backport to release/8.0

@github-actions

github-actions Bot commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/12676535260

@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 8, 2025
@github-actions

github-actions Bot commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

@wtgodbe backporting to release/8.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Pin to S.T.J 8.0.5 in Analyzers
Using index info to reconstruct a base tree...
M	eng/Versions.props
Falling back to patching base and 3-way merge...
Auto-merging eng/Versions.props
CONFLICT (content): Merge conflict in eng/Versions.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Pin to S.T.J 8.0.5 in Analyzers
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@wtgodbe wtgodbe closed this Jan 8, 2025
@wtgodbe
wtgodbe deleted the wtgodbe/STJ90 branch January 8, 2025 20:12
@dotnet-policy-service dotnet-policy-service Bot modified the milestones: 9.0.x, 9.0.2 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.