[release/9.0] Harden parsing of [Range] attribute values - #59077
#59077Merged
wtgodbe merged 1 commit intoNov 27, 2024
release/9.0dotnet/aspnetcore:release/9.0from
backport/pr-59043-to-release/9.0dotnet/aspnetcore:backport/pr-59043-to-release/9.0Copy head branch name to clipboard
Merged
[release/9.0] Harden parsing of [Range] attribute values#59077wtgodbe merged 1 commit intorelease/9.0dotnet/aspnetcore:release/9.0from backport/pr-59043-to-release/9.0dotnet/aspnetcore:backport/pr-59043-to-release/9.0Copy head branch name to clipboard
wtgodbe merged 1 commit into
release/9.0dotnet/aspnetcore:release/9.0from
backport/pr-59043-to-release/9.0dotnet/aspnetcore:backport/pr-59043-to-release/9.0Copy head branch name to clipboard
Conversation
github-actions
Bot
requested review from
a team and
captainsafia
as code owners
November 20, 2024 16:30
mitchdenny
approved these changes
Nov 22, 2024
Contributor
|
Approved via email. |
This was referenced Jan 15, 2025
This was referenced Jul 22, 2025
Closed
Merged
This was referenced Jul 20, 2026
Open
Closed
Closed
Closed
Bump Microsoft.AspNetCore.Authentication.Google from 9.0.0 to 9.0.18
isaacwallace123/portfolio-v3#21
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59043 to release/9.0
/cc @captainsafia
Description
This change hardens the parsing logic for
[Range]attributes to handle:minimumandmaximumkeywords in the OpenAPI schema, likeDateTime.RangeAttribute.ParseLimitsInInvariantCulture.For scenarios where the range value is too large to be represented as a decimal, this implementation will no-op and not set the corresponding minimum or maximum in the OpenAPI document.
Fixes #57390
Customer Impact
Prevents unhandled exceptions when customers use the
Range(object, object)overloads of theRangeattribute instead of those that take a double/integer. There's no immediate workarounds for this bug outside of removing the attribute.Regression?
Risk
Change localized to
Rangeattribute handling in OpenAPI package.Verification
Packaging changes reviewed?