Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[release/8.0] Use MacOS-13 in CI - #58549

#58549
Merged
wtgodbe merged 8 commits into
release/8.0dotnet/aspnetcore:release/8.0from
wtgodbe/Mac138.0dotnet/aspnetcore:wtgodbe/Mac138.0Copy head branch name to clipboard
Nov 14, 2024
Merged

[release/8.0] Use MacOS-13 in CI#58549
wtgodbe merged 8 commits into
release/8.0dotnet/aspnetcore:release/8.0from
wtgodbe/Mac138.0dotnet/aspnetcore:wtgodbe/Mac138.0Copy head branch name to clipboard

Conversation

@wtgodbe

@wtgodbe wtgodbe commented Oct 21, 2024

Copy link
Copy Markdown
Member

No description provided.

@wtgodbe
wtgodbe requested review from a team, BrennanConroy and halter73 as code owners October 21, 2024 17:17
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 21, 2024
@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Oct 21, 2024
@dotnet-policy-service dotnet-policy-service Bot added this to the 8.0.x milestone Oct 21, 2024
@dotnet-policy-service dotnet-policy-service Bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Oct 28, 2024
@wtgodbe

wtgodbe commented Nov 5, 2024

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@wtgodbe

wtgodbe commented Nov 13, 2024

Copy link
Copy Markdown
Member Author

A JSON parsing exception occurred in [/__w/1/s/artifacts/source-build/self/src/global.json], offset 743 (line 31, column 1): Missing a comma or '}' after an object member.

@dotnet/source-build any idea why the global.json changes in this PR would cause a JSON parsing error, only in the source-build job? The JSON in global.json does appear to be valid, so not sure what's going on

@mthalman

Copy link
Copy Markdown
Member

A JSON parsing exception occurred in [/__w/1/s/artifacts/source-build/self/src/global.json], offset 743 (line 31, column 1): Missing a comma or '}' after an object member.

@dotnet/source-build any idea why the global.json changes in this PR would cause a JSON parsing error, only in the source-build job? The JSON in global.json does appear to be valid, so not sure what's going on

I suspect it's because the trailing newline was removed from the end of the file. I added it back.

@wtgodbe

wtgodbe commented Nov 14, 2024

Copy link
Copy Markdown
Member Author

I suspect it's because the trailing newline was removed from the end of the file. I added it back.

Interesting, is that a known thing w/ how SourceBuild parses global.json? I'm curious why it only happened there

@mthalman

Copy link
Copy Markdown
Member

I suspect it's because the trailing newline was removed from the end of the file. I added it back.

Interesting, is that a known thing w/ how SourceBuild parses global.json? I'm curious why it only happened there

Not specific to source build. It's a general Linux thing. Certain Linux tools do not play nicely with files formatted that way. That's why GitHub has UI that alerts you to a missing newline. So likely source build is executing something in the context of Linux that doesn't like this.

@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Nov 14, 2024
@wtgodbe

wtgodbe commented Nov 14, 2024

Copy link
Copy Markdown
Member Author

Failures unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.