Notify about missing opposite-dir subs - #6414
#6414Merged
adamzip merged 12 commits intoJun 24, 2026
dotnet:maindotnet/arcade-services:mainfrom
adamzip:notify-missing-opposite-subadamzip/arcade-services:notify-missing-opposite-subCopy head branch name to clipboard
Merged
Notify about missing opposite-dir subs#6414adamzip merged 12 commits intodotnet:maindotnet/arcade-services:mainfrom adamzip:notify-missing-opposite-subadamzip/arcade-services:notify-missing-opposite-subCopy head branch name to clipboard
adamzip merged 12 commits into
dotnet:maindotnet/arcade-services:mainfrom
adamzip:notify-missing-opposite-subadamzip/arcade-services:notify-missing-opposite-subCopy head branch name to clipboard
Conversation
premun
reviewed
Jun 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a warning comment to newly created codeflow pull requests when an opposite-direction (reverse) codeflow subscription appears to be missing, helping repos detect incomplete bidirectional subscription setup.
Changes:
- Invoke a new notification step after codeflow PR creation to detect missing opposite-direction subscriptions.
- Add subscription lookup logic in
CodeFlowPullRequestUpdaterto determine whether the reverse flow exists for relevant channels. - Add a new
PullRequestCommentBuilderhelper to format the warning message.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/ProductConstructionService/ProductConstructionService.DependencyFlow/PullRequestUpdaters/CodeFlowPullRequestUpdater.cs | Adds best-effort detection and PR warning emission for missing opposite-direction subscriptions during codeflow PR creation. |
| src/ProductConstructionService/ProductConstructionService.DependencyFlow/PullRequestCommentBuilder.cs | Adds a new builder method to format the “missing opposite-direction subscription” PR warning text. |
premun
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5374
Sample pr: maestro-auth-test/maestro-test-vmr#7077